CherryPicked: [cnv-4.20] [CNV4.21][IUO] Migrate install, upgrade and EUS upgrade paths to Konflux IDMS#4080
Open
openshift-virtualization-qe-bot-5 wants to merge 1 commit intocnv-4.20from
Conversation
…lux IDMS (#4076) Manual Cherry pick of #4070 and #4061 ##### Short description: CNV operator builds migrated from Brew to Konflux, so install, upgrade and EUS upgrade test paths now require Konflux IDMS instead of the legacy ICSP/IDMS generated via `oc adm catalog mirror`. This change consolidates Konflux IDMS helpers (apply_konflux_idms, idms_has_all_mirrors) into tests/install_upgrade_operators/utils.py, removes the legacy ICSP fixtures from install, upgrade and EUS upgrade conftest files, and replaces them with Konflux-based fixtures: - Install path: installed_konflux_idms (product_install/conftest.py) - Upgrade path: updated_konflux_idms (product_upgrade/conftest.py) - EUS upgrade path: eus_updated_konflux_idms (product_upgrade/conftest.py) ##### More details: N/A ##### What this PR does / why we need it: N/A ##### Which issue(s) this PR fixes: N/A ##### Special notes for reviewer: N/A ##### jira-ticket: N/A Co-authored-by: Claude Opus 4.6 <noreply@anthropic.com>
Contributor
|
Important Review skippedAuto reviews are disabled on base/target branches other than the default branch. Please check the settings in the CodeRabbit UI or the ⚙️ Run configurationConfiguration used: Organization UI Review profile: CHILL Plan: Pro Run ID: You can disable this status message by setting the Use the checkbox below for a quick retry:
✨ Finishing Touches🧪 Generate unit tests (beta)
Tip Try Coding Plans. Let us write the prompt for your AI agent so you can ship faster (with fewer bugs). Thanks for using CodeRabbit! It's free for OSS, and your support helps us grow. If you like it, consider giving us a shout-out. Comment |
|
Report bugs in Issues Welcome! 🎉This pull request will be automatically processed with the following features:
🔄 Automatic Actions
📋 Available CommandsPR Status Management
Review & Approval
Testing & Validation
Container Operations
Cherry-pick Operations
Label Management
✅ Merge RequirementsThis PR will be automatically approved when the following conditions are met:
📊 Review ProcessApprovers and ReviewersApprovers:
Reviewers:
Available Labels
💡 Tips
For more information, please refer to the project documentation or contact the maintainers. |
openshift-virtualization-qe-bot
requested review from
RoniKishner,
albarker-rh,
hmeir,
rlobillo and
vsibirsk
openshift-virtualization-qe-bot
added
tox:verify-tc-requirement-polarion:running
Contributor
|
/verified Installing CNV4.19.15 and upgrading to CNV4.20.7 finished succesfully |
Contributor
Test execution plan request detailsCRITICAL: You MUST post an inline review comment on the first changed line of the first file. As an expert software testing engineer, analyze all modified files in this PR and create a targeted test execution plan. Analysis Requirements:
Your deliverable: Test Execution Plan
Guidelines:
Hardware-Related Checks (SR-IOV, GPU, DPDK): When PR modifies fixtures for hardware-specific resources:
CRITICAL WORKFLOW COMPLETION RULES: When responding to this test execution plan request, you MUST follow these rules EXACTLY:
ABSOLUTE PROHIBITIONS (violating these creates empty/meaningless reviews):
Remember: The pull request review is visible to users. Additional comments are redundant noise. CRITICAL: Before setting "Run smoke tests: True", you MUST use shell scripts to: |
![coderabbitai[bot]](https://avatars.githubusercontent.com/in/347564?s=60&v=4){kind=small}
| from ocp_resources.cluster_service_version import ClusterServiceVersion | ||
| from ocp_resources.hostpath_provisioner import HostPathProvisioner | ||
| from ocp_resources.hyperconverged import HyperConverged | ||
| from ocp_resources.image_digest_mirror_set import ImageDigestMirrorSet |
Contributor
There was a problem hiding this comment.
Test Execution Plan
-
Run smoke tests: False
tests/install_upgrade_operators/csv/test_csv.pyhaspytest.mark.smokebut has no reference to any changed fixture or utility; no dependency path exists.
-
tests/install_upgrade_operators/product_install/— all install tests;installed_konflux_idmsfixture replaces the old ICSP/IDMS generation chain -
tests/install_upgrade_operators/product_upgrade/test_upgrade.py::test_cnv_upgrade_process— fixtureupdated_konflux_idmsreplacesupdated_image_content_source_policy -
-m eus— EUS upgrade path now useseus_updated_konflux_idmsinstead ofeus_applied_all_icsp
Contributor
There was a problem hiding this comment.
Tested install and upgrade. EUS will be tested separatedly.
Contributor
|
Tip For best results, initiate chat on the files or code changes. 🧩 Analysis chain🏁 Script executed: Length of output: 224 🏁 Script executed: Length of output: 17129 🏁 Script executed: Length of output: 920 🏁 Script executed: Length of output: 1735 🧠 Learnings used |
Collaborator
|
/approve |
Collaborator
|
/approve cancel |
Contributor
|
/retest tox |
Contributor
|
/close in favour of #4083 |
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
8 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Cherry-pick from
cnv-4.21branch, original PR: #4076, PR owner: rlobillo