Conversation
This change introduces a suffix to the built artifact to facilitate multi-architecture image testing. Without this modification, a race condition occurs when the jobs for s390x and x86_64 run in parallel. Signed-off-by: Nestor Acuna Blanco <nestor.acuna@ibm.com>
Most of the code is a copy-paste from the amd64 section. The main difference is that qemu-system-s390x must be installed instead of x86. After the job runs, an s390x artifact should be published. Signed-off-by: Nestor Acuna Blanco <nestor.acuna@ibm.com>
The build.sh script primarily utilizes environment variables. To generate an image for a new architecture, these variables must be adjusted. This change relocates the generic environment variables to specific steps, facilitating the transition to multiarch building. Signed-off-by: Nestor Acuna Blanco <nestor.acuna@ibm.com>
This change enables the publication of the Fedora s390x image alongside the amd64 image in a single manifest. To achieve this, the following steps must be taken: 1. Install qemu-system-s390x. 2. Execute build.sh twice with different environment variables. After completing these steps, both the amd64 and s390x images should be added to the manifest. Signed-off-by: Nestor Acuna Blanco <nestor.acuna@ibm.com>
|
Important Review skippedDraft detected. Please check the settings in the CodeRabbit UI or the ⚙️ Run configurationConfiguration used: Path: .coderabbit.yaml Review profile: ASSERTIVE Plan: Pro Run ID: You can disable this status message by setting the Use the checkbox below for a quick retry:
✨ Finishing Touches🧪 Generate unit tests (beta)
Tip Try Coding Plans. Let us write the prompt for your AI agent so you can ship faster (with fewer bugs). Thanks for using CodeRabbit! It's free for OSS, and your support helps us grow. If you like it, consider giving us a shout-out. Comment |
openshift-virtualization-qe-bot
added
tox:verify-tc-requirement-polarion:running
| sudo apt-get update | ||
| sudo apt-get install -y \ | ||
| qemu-system-x86 \ | ||
| qemu-system-s390x \ |
There was a problem hiding this comment.
we should install only one, based on arch
| working-directory: ./containers/fedora | ||
| run: wget -q "https://download.fedoraproject.org/pub/fedora/linux/releases/41/Cloud/x86_64/images/${{ env.FEDORA_IMAGE }}" | ||
| env: | ||
| FEDORA_IMAGE: Fedora-Cloud-Base-Generic-41-1.4.x86_64.qcow2 |
There was a problem hiding this comment.
can we have these as vars at the top for easier updating (and they are repeated in the code)
| # https://bugs.launchpad.net/ubuntu/+source/linux/+bug/759725 | ||
| run: sudo chmod 0644 /boot/vmlinuz* | ||
| - name: Fetch base Fedora image | ||
| - name: Fetch base Fedora amd64 image |
There was a problem hiding this comment.
how about using tools like https://github.com/qoomon/actions--parallel-steps to have steps run in parallel, or use gh matrix yo avoid code duplication
| @@ -10,12 +10,10 @@ on: | |||
| workflow_dispatch: | |||
|
|
|||
| jobs: | |||
There was a problem hiding this comment.
the flow here should be to promote the built images in component-builder to production -i.e not re-build again.
we need also arm support
4 participants
Open for discussion, since Fedora41 is no longer available, and we would need to change to 43 once the the distribution is tested.