Skip to content

[test only ] test pr 4.21 #4059

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Closed
rnetser wants to merge 1 commit into from
Closed

[test only ] test pr 4.21 #4059

Changes from all commits
Commits
Show all changes
1 commit
Select commit
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
5 changes: 3 additions & 2 deletions tests/conftest.py
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -251,9 +251,10 @@ def kubeconfig_export_path():


@pytest.fixture(scope="session")
def exported_kubeconfig(unprivileged_secret, kubeconfig_export_path):
def exported_kubeconfig(admin_client, unprivileged_secret, kubeconfig_export_path):
Copy link
Contributor

@coderabbitai coderabbitai bot Mar 4, 2026

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Test Execution Plan

  • Run smoke tests: True
    • Dependency chain confirmed: test_container_disk_vm (smoke, @pytest.mark.smoke) → unprivileged_client → exported_kubeconfig (changed)
  • tests/virt/node/general/test_container_disk_vm.py — smoke test depends on unprivileged_client which uses exported_kubeconfig
  • tests/conftest.py — verify exported_kubeconfig and unprivileged_client fixture behaviour with and without unprivileged_secret

if not unprivileged_secret:
yield
LOGGER.error("test message in exported_kubeconfig")
yield admin_client

else:
kube_config_path = os.path.join(os.path.expanduser("~"), ".kube/config")
Expand Down