[IUO] use full API version (group/version) for HCO resource#3998
[IUO] use full API version (group/version) for HCO resource#3998hmeir wants to merge 1 commit intoRedHatQE:mainfrom
Conversation
Setting hco.api_version to just "v1beta1" instead of "hco.kubevirt.io/v1beta1" causes failures in ResourceEditor
|
No actionable comments were generated in the recent review. 🎉 ℹ️ Recent review infoConfiguration used: Path: .coderabbit.yaml Review profile: ASSERTIVE Plan: Pro 📒 Files selected for processing (1)
📝 WalkthroughWalkthroughThe change modifies the HyperConverged resource lookup in utilities/infra.py to construct the API version string by combining an API group prefix with the version identifier, replacing direct version constant usage. Changes
Estimated code review effort🎯 1 (Trivial) | ⏱️ ~3 minutes 🚥 Pre-merge checks | ✅ 1 | ❌ 2❌ Failed checks (2 warnings)
✅ Passed checks (1 passed)
✏️ Tip: You can configure your own custom pre-merge checks in the settings. ✨ Finishing Touches🧪 Generate unit tests (beta)
Thanks for using CodeRabbit! It's free for OSS, and your support helps us grow. If you like it, consider giving us a shout-out. Comment |
|
Report bugs in Issues Welcome! 🎉This pull request will be automatically processed with the following features: 🔄 Automatic Actions
📋 Available CommandsPR Status Management
Review & Approval
Testing & Validation
Container Operations
Cherry-pick Operations
Label Management
✅ Merge RequirementsThis PR will be automatically approved when the following conditions are met:
📊 Review ProcessApprovers and ReviewersApprovers:
Reviewers:
Available Labels
💡 Tips
For more information, please refer to the project documentation or contact the maintainers. |
Codecov Report✅ All modified and coverable lines are covered by tests. Additional details and impacted files@@ Coverage Diff @@
## main #3998 +/- ##
==========================================
+ Coverage 98.56% 98.60% +0.04%
==========================================
Files 25 25
Lines 2297 2368 +71
==========================================
+ Hits 2264 2335 +71
Misses 33 33
Flags with carried forward coverage won't be shown. Click here to find out more. ☔ View full report in Codecov by Sentry. 🚀 New features to boost your workflow:
|
![coderabbitai[bot]](https://avatars.githubusercontent.com/in/347564?s=60&v=4){kind=small}
openshift-virtualization-qe-bot
added
tox:verify-tc-requirement-polarion:running
| name=hco_name, | ||
| ) | ||
| hco.api_version = hco.ApiVersion.V1BETA1 | ||
| hco.api_version = f"{hco.ApiGroup.HCO_KUBEVIRT_IO}/{hco.ApiVersion.V1BETA1}" |
There was a problem hiding this comment.
can you share the errors? at the time i tried and did not see any
There was a problem hiding this comment.
sure
cailed on setup with "kubernetes.dynamic.exceptions.BadRequestError: 400
Reason: Bad Request
HTTP response headers: HTTPHeaderDict({'Audit-Id': 'de36bd53-ec5a-485b-9a1e-8216ccd418ad', 'Cache-Control': 'no-cache, private', 'Content-Type': 'application/json', 'Strict-Transport-Security': 'max-age=31536000; includeSubDomains; preload', 'X-Kubernetes-Pf-Flowschema-Uid': 'c5b5aa81-2097-4133-ac9e-f487467646d0', 'X-Kubernetes-Pf-Prioritylevel-Uid': 'a61ff2c8-5ba3-4bbc-ac7f-1ff4218ddcab', 'Date': 'Sun, 01 Mar 2026 20:39:17 GMT', 'Content-Length': '218'})
HTTP response body: b'{"kind":"Status","apiVersion":"v1","metadata":{},"status":"Failure","message":"the API version in the data (v1beta1) does not match the expected API version (hco.kubevirt.io/v1beta1)","reason":"BadRequest","code":400}\n'
There was a problem hiding this comment.
weird, thanks for the info
you can resolve
|
/approve |
6 participants
Short description:
Setting hco.api_version to just "v1beta1" instead of "hco.kubevirt.io/v1beta1" causes failures in ResourceEditor
More details:
What this PR does / why we need it:
Which issue(s) this PR fixes:
Special notes for reviewer:
jira-ticket:
Summary by CodeRabbit