Open
Conversation
Contributor
|
Important Review skippedReview was skipped due to path filters ⛔ Files ignored due to path filters (1)
CodeRabbit blocks several paths by default. You can override this behavior by explicitly including those paths in the path filters. For example, including ⚙️ Run configurationConfiguration used: Path: .coderabbit.yaml Review profile: ASSERTIVE Plan: Pro Run ID: You can disable this status message by setting the Use the checkbox below for a quick retry:
✨ Finishing Touches🧪 Generate unit tests (beta)
Thanks for using CodeRabbit! It's free for OSS, and your support helps us grow. If you like it, consider giving us a shout-out. Comment |
![coderabbitai[bot]](https://avatars.githubusercontent.com/in/347564?s=60&v=4){kind=small}
Contributor
|
Report bugs in Issues Welcome! 🎉This pull request will be automatically processed with the following features: 🔄 Automatic Actions
📋 Available CommandsPR Status Management
Review & Approval
Testing & Validation
Container Operations
Cherry-pick Operations
Label Management
✅ Merge RequirementsThis PR will be automatically approved when the following conditions are met:
📊 Review ProcessApprovers and ReviewersApprovers:
Reviewers:
Available Labels
💡 Tips
For more information, please refer to the project documentation or contact the maintainers. |
openshift-virtualization-qe-bot
added
tox:verify-tc-requirement-polarion:running
dshchedr
previously approved these changes
Feb 26, 2026
rnetser
requested changes
Mar 1, 2026
CLAUDE.md
Outdated
| - **No dead code** - every function, variable, fixture MUST be used or removed. Code marked with `# skip-unused-code` is excluded from dead code analysis (enforced via custom ruff plugin). | ||
| - **Prefer direct attribute access** - use `foo.attr` directly. Save to variables only when: reusing the same attribute multiple times improves readability, or extracting clarifies intent. | ||
| - **Imports always at the top of the module** - do not import inside functions | ||
| - **New functions and helpers don't belong in `conftest.py`** - new functions and helpers belong in libs, conftest is for fixtures |
Collaborator
There was a problem hiding this comment.
currently we do not use libs across the repo so it is better to explicily state that functions and classes must not be under conftest.py or test_*.py files.
CLAUDE.md
Outdated
| - **Tests MUST be independent** - use `pytest-dependency` ONLY when test B requires side effects from test A (e.g., cluster-wide configuration). | ||
| For resource dependencies, use shared fixtures instead. **When using `@pytest.mark.dependency`, a comment explaining WHY the dependency exists is REQUIRED.** | ||
| - **ALWAYS use `@pytest.mark.usefixtures`** - REQUIRED when fixture return value is not used by test | ||
| - **Do not offer to use `pytest.skip()` or `@pytest.mark.skip` or `@pytest.mark.skipif`** - programmatic skips in this repo are not allowed |
Collaborator
There was a problem hiding this comment.
please rephrase
pytest skip and skipif options are forbidden.
azhivovk
dismissed stale reviews from dshchedr and coderabbitai[bot]
via
26e7d86
Contributor
Author
|
Change: Rephrase |
openshift-virtualization-qe-bot
added
lgtm-rnetser
and removed
changes-requested-rnetser
labels
Collaborator
|
@azhivovk you can ask coderabbitai to review the pr and ask the bot if this text is good |
Contributor
Author
|
@coderabbitai can you review this PR and ensure the instructions are okay? |
Contributor
|
Tip For best results, initiate chat on the files or code changes. 🧩 Analysis chain🏁 Script executed: Length of output: 1846
✅
|
Contributor
|
/retest all Auto-triggered: Files in this PR were modified by merged PR #2881. Overlapping filesCLAUDE.md |
Signed-off-by: Asia Khromov <azhivovk@redhat.com>
azhivovk
dismissed stale reviews from rnetser, vsibirsk, and coderabbitai[bot]
via
6b63f9f
Contributor
Author
|
Change: Apply bot's suggestion |
openshift-virtualization-qe-bot
added
tox:verify-tc-requirement-polarion:running
Contributor
Author
|
/verified |
Contributor
Test execution plan request detailsCRITICAL: You MUST post an inline review comment on the first changed line of the first file. As an expert software testing engineer, analyze all modified files in this PR and create a targeted test execution plan. Analysis Requirements:
Your deliverable: Test Execution Plan
Guidelines:
Hardware-Related Checks (SR-IOV, GPU, DPDK): When PR modifies fixtures for hardware-specific resources:
CRITICAL WORKFLOW COMPLETION RULES: When responding to this test execution plan request, you MUST follow these rules EXACTLY:
ABSOLUTE PROHIBITIONS (violating these creates empty/meaningless reviews):
Remember: The pull request review is visible to users. Additional comments are redundant noise. CRITICAL: Before setting "Run smoke tests: True", you MUST use shell scripts to: |
Contributor
|
Tip For best results, initiate chat on the files or code changes. 🧩 Analysis chain🏁 Script executed: Length of output: 2031 🏁 Script executed: Length of output: 1735 🧠 Learnings used |
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
9 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Add instructions to claude due to repetitive errors: Avoid programmatic skips, imports always at the top of the module, and keep conftest.py for fixtures