Conversation
|
Note Reviews pausedIt looks like this branch is under active development. To avoid overwhelming you with review comments due to an influx of new commits, CodeRabbit has automatically paused this review. You can configure this behavior by changing the Use the following commands to manage reviews:
Use the checkboxes below for quick actions:
WalkthroughAdds a new OpenShift Virtualization Quality Engineering Plan document ( Changes
Estimated code review effort🎯 3 (Moderate) | ⏱️ ~20 minutes 🚥 Pre-merge checks | ✅ 4✅ Passed checks (4 passed)
✏️ Tip: You can configure your own custom pre-merge checks in the settings. ✨ Finishing Touches🧪 Generate unit tests (beta)
Tip Issue Planner is now in beta. Read the docs and try it out! Share your feedback on Discord. Thanks for using CodeRabbit! It's free for OSS, and your support helps us grow. If you like it, consider giving us a shout-out. Comment |
|
Report bugs in Issues Welcome! 🎉This pull request will be automatically processed with the following features: 🔄 Automatic Actions
📋 Available CommandsPR Status Management
Review & Approval
Testing & Validation
Container Operations
Cherry-pick Operations
Label Management
✅ Merge RequirementsThis PR will be automatically approved when the following conditions are met:
📊 Review ProcessApprovers and ReviewersApprovers:
Reviewers:
Available Labels
💡 Tips
For more information, please refer to the project documentation or contact the maintainers. |
![coderabbitai[bot]](https://avatars.githubusercontent.com/in/347564?s=60&v=4){kind=small}
There was a problem hiding this comment.
Actionable comments posted: 2
🤖 Fix all issues with AI agents
In @stps/sig-iuo/golden_image_multiarch_support.md:
- Line 25: The term label "Muliarch FG" contains a typo; update it to "MultiArch
FG" to match the existing "MultiArch cluster" terminology and keep consistency
with the feature gate name `enableMultiArchBootImageImport` in the same row
(change the display string for that table cell only).
- Around line 160-169: The out-of-scope table rows (e.g., "Update existing VM",
"Performance Testing", "Security Testing", "Usability testing", "Compatibility",
"Templates creation & utilization", "Imports & datasource new API", "Testing
with s390x architecture") are missing required PM/Lead sign-offs; update each
checkbox from "[ ]" to "[x] Name/Date" with the actual stakeholder name and date
for every listed item, and if a sign-off cannot be obtained immediately add a
short escalation note next to the item (e.g., "Pending: escalate to PM/Lead -
Date") to surface the risk per the document guidance.
📜 Review details
Configuration used: Organization UI
Review profile: CHILL
Plan: Pro
📒 Files selected for processing (1)
stps/sig-iuo/golden_image_multiarch_support.md
🧰 Additional context used
🪛 LanguageTool
stps/sig-iuo/golden_image_multiarch_support.md
[style] ~53-~53: You have already used this phrasing in nearby sentences. Consider replacing it to add variety to your writing.
Context: ...usters.
2. As a cluster admin, I want to define custom golden images with multi-...
(REP_WANT_TO_VB)
[style] ~278-~278: You have already used this phrasing in nearby sentences. Consider replacing it to add variety to your writing.
Context: ... US2 | As a cluster admin, I want to define custom golden images with multi-...
(REP_WANT_TO_VB)
[style] ~279-~279: You have already used this phrasing in nearby sentences. Consider replacing it to add variety to your writing.
Context: ... | As a VM creator/cluster admin, I want to create VMs / custom golden images for s...
(REP_WANT_TO_VB)
[style] ~280-~280: You have already used this phrasing in nearby sentences. Consider replacing it to add variety to your writing.
Context: ... US2, US3 | As a cluster admin, I want to define custom golden images for specifi...
(REP_WANT_TO_VB)
[style] ~283-~283: You have already used this phrasing in nearby sentences. Consider replacing it to add variety to your writing.
Context: ... US2 | As a cluster admin, I want to define custom golden images with multi-...
(REP_WANT_TO_VB)
[style] ~287-~287: You have already used this phrasing in nearby sentences. Consider replacing it to add variety to your writing.
Context: ... | As a VM creator/cluster admin, I want to create VMs / custom golden images for s...
(REP_WANT_TO_VB)
[style] ~288-~288: You have already used this phrasing in nearby sentences. Consider replacing it to add variety to your writing.
Context: ...US3 | As a VM creator/cluster admin, I want to create VMs / define custom golden image...
(REP_WANT_TO_VB)
🔇 Additional comments (9)
stps/sig-iuo/golden_image_multiarch_support.md (9)
43-57: Requirements review is comprehensive.The checklist covers all essential aspects: requirements, value propositions, use cases, testability, acceptance criteria, and NFRs. The user stories are well-articulated with clear value statements.
125-144: Test goals are well-defined and prioritized.The functional, monitoring, backward compatibility, and upgrade goals are specific, measurable, and properly prioritized (P0/P1). Good coverage of all key aspects of the feature.
176-190: Test strategy coverage is comprehensive.The test strategy table appropriately covers functional, automation, upgrade, and backward compatibility testing. The N/A justifications for performance, security, compatibility, and regression testing are reasonable given the feature scope.
248-258: Known limitations are well-documented.The three limitations are clearly stated with appropriate scope:
- Existing VMs not automatically updated
- Platform variant formats not supported
- Architecture validation is user responsibility
These set clear expectations for users and testers.
275-288: Excellent requirements-to-test traceability.The traceability matrix provides clear mapping from user stories to test scenarios with appropriate tier and priority assignments. Each requirement is covered by at least one test scenario, ensuring comprehensive coverage.
1-301: Overall: Well-structured test plan with strong technical content.This is a comprehensive Quality Engineering Test Plan that demonstrates thorough analysis of the multi-architecture golden images feature. Strengths include:
- Clear requirements and user stories with value propositions
- Well-prioritized test goals (P0/P1)
- Comprehensive test strategy covering functional, monitoring, upgrade, and backward compatibility
- Good requirements-to-test traceability
- Transparent documentation of risks and limitations
The main gaps are process-related (stakeholder agreements, sign-offs, risk resolution) rather than technical content, which should be addressed before finalizing the plan.
292-301: Replace placeholder stakeholder names with actual reviewers and approvers.The sign-off section contains four instances of placeholder text "[Name / @github-username]" under Reviewers and Approvers. Since this Software Test Plan explicitly requires approval from stakeholders, fill in the actual names and GitHub usernames of those responsible for signing off.
237-246: Clarify intent of unchecked status boxes—they appear intentional in this planning document.The unchecked [ ] status in the risks table is typical for design documents tracking future mitigation work. However, there is one inconsistency: Resource Constraints lists the risk as "N/A" with no specific risk identified, yet the status is [ ] instead of [X]. Either mark it [X] to indicate N/A risks are not a concern, or document a specific risk if applicable.
The risk documentation itself is well-structured with clear mitigation strategies and related ticket references. No action needed on the remaining unchecked items—they correctly reflect work pending mitigation as the feature progresses.
Likely an incorrect or invalid review comment.
221-227: Entry criterion appropriately tracked via dependencies.The unchecked criterion "Multi-CPU architecture support enabled in openshift-virtualization repo" is intentionally tracked in the Risks section (line 244) as a documented dependency with a specific action: "Review the PR whenever its ready to review." Since this document is in Draft status, unchecked entry criteria represent planned activities being tracked, not blockers.
Likely an incorrect or invalid review comment.
There was a problem hiding this comment.
Actionable comments posted: 6
🤖 Fix all issues with AI agents
In @stps/sig-iuo/golden_image_multiarch_support.md:
- Around line 275-289: The Requirement ID column in the table is empty which
breaks traceability; update each row in the table (the header "Requirement ID"
and the subsequent entries in golden_image_multiarch_support.md) by filling the
leftmost cell with the appropriate Jira issue keys (e.g., CNV-12345 style) that
map to the described requirement/test scenario so every row has a unique
Requirement ID for traceability.
- Line 256: Update the known limitation sentence "Existing VMs not updated: VMs
that are already running will not automatically use new architecture-specific
resources. Users must recreate VMs to take advantage of new resources." to
include the missing verb by changing "Existing VMs not updated:" to "Existing
VMs are not updated:" so the statement reads grammatically correct and retains
the same meaning.
- Line 162: The rationale sentence "If a VM already running, it won't use the
arch-specific resources" is missing the verb "is"; update the text to read "If a
VM is already running, it won't use the arch-specific resources" so the sentence
is grammatically correct (look for that exact phrase in the
golden_image_multiarch_support.md content).
- Line 3: Remove the trailing extra asterisk from the Markdown title string "HCO
support for heterogeneous multi-arch clusters (golden images support) - Quality
Engineering Plan**" so it reads "...Quality Engineering Plan" (without the final
**), ensuring the header is properly formatted.
- Line 55: The Testability table row text is awkward; update the third column
(the cell currently reading "Everything is testable, despite upgrade to a
version which this FG enabled by default.") to a clear, grammatical sentence
such as: "All tests remain valid after upgrading to a version where this feature
gate is enabled by default." Keep the fourth column note ("Should be done in
4.22 timeframe") as-is unless you want to rephrase scheduling language for
consistency.
- Line 25: Update the typo "Muliarch FG" to "MultiArch FG" in the document where
the table entry defines the term for the feature gate; specifically replace the
string "Muliarch FG" with "MultiArch FG" in the row that references the
`enableMultiArchBootImageImport` feature gate so the spelling matches the rest
of the document.
🧹 Nitpick comments (1)
stps/sig-iuo/golden_image_multiarch_support.md (1)
292-301: Complete sign-off section before finalization.The reviewers and approvers sections contain placeholder names. Ensure these are updated with actual names and GitHub usernames before the test plan is finalized and marked as approved.
📜 Review details
Configuration used: Organization UI
Review profile: CHILL
Plan: Pro
📒 Files selected for processing (1)
stps/sig-iuo/golden_image_multiarch_support.md
🧰 Additional context used
🧠 Learnings (1)
📚 Learning: 2026-01-08T17:18:15.313Z
Learnt from: yossisegev
Repo: RedHatQE/openshift-virtualization-tests-design-docs PR: 7
File: stps/sig-network/ip-request-stp.md:0-0
Timestamp: 2026-01-08T17:18:15.313Z
Learning: In the repository RedHatQE/openshift-virtualization-tests-design-docs, the preferred style is "3rd party" without hyphenation, not "third-party".
Applied to files:
stps/sig-iuo/golden_image_multiarch_support.md
🪛 LanguageTool
stps/sig-iuo/golden_image_multiarch_support.md
[style] ~53-~53: You have already used this phrasing in nearby sentences. Consider replacing it to add variety to your writing.
Context: ...usters.
2. As a cluster admin, I want to define custom golden images with multi-...
(REP_WANT_TO_VB)
[style] ~278-~278: You have already used this phrasing in nearby sentences. Consider replacing it to add variety to your writing.
Context: ... | As a cluster admin, I want to define custom golden images with multi-...
(REP_WANT_TO_VB)
[style] ~279-~279: You have already used this phrasing in nearby sentences. Consider replacing it to add variety to your writing.
Context: ... | As a VM creator/cluster admin, I want to create VMs / custom golden images for s...
(REP_WANT_TO_VB)
[style] ~280-~280: You have already used this phrasing in nearby sentences. Consider replacing it to add variety to your writing.
Context: ... | As a cluster admin, I want to define custom golden images for specifi...
(REP_WANT_TO_VB)
[style] ~283-~283: You have already used this phrasing in nearby sentences. Consider replacing it to add variety to your writing.
Context: ... | As a cluster admin, I want to define custom golden images with multi-...
(REP_WANT_TO_VB)
[style] ~287-~287: You have already used this phrasing in nearby sentences. Consider replacing it to add variety to your writing.
Context: ... | As a VM creator/cluster admin, I want to create VMs / custom golden images for s...
(REP_WANT_TO_VB)
[style] ~288-~288: You have already used this phrasing in nearby sentences. Consider replacing it to add variety to your writing.
Context: ... | As a VM creator/cluster admin, I want to create VMs / define custom golden image...
(REP_WANT_TO_VB)
🔇 Additional comments (3)
stps/sig-iuo/golden_image_multiarch_support.md (3)
29-35: LGTM! Clear and comprehensive feature overview.The feature overview effectively describes the multi-architecture golden image support, its customer value, and the technical components involved (HCO, SSP, CDI coordination).
160-169: Obtain PM/Lead sign-off for out-of-scope items.The template explicitly states that "All out-of-scope items require explicit stakeholder agreement" and "each out-of-scope item must have PM/Lead sign-off." Currently, all items in the PM/Lead Agreement column are unchecked.
Ensure each out-of-scope item is reviewed and approved by the appropriate stakeholder before finalizing this test plan.
227-227: Complete or document status of entry criterion.The entry criterion "Multi-CPU architecture support enabled in openshift-virtualization repo" is unchecked. Verify whether this is complete or document the blocking status.
There was a problem hiding this comment.
Actionable comments posted: 4
🤖 Fix all issues with AI agents
In @stps/sig-iuo/golden_image_multiarch_support.md:
- Around line 275-288: The Requirement ID column in the traceability table is
empty; populate each row with the corresponding Jira issue key so every
requirement traces back to a testable Jira item (follow the doc guidance to use
keys like CNV-12345); either create new Jira issues for each user story/test
scenario or reference parent tickets (e.g., CNV-67900, VIRTSTRAT-494) with
sub-task IDs, and update the table so every row in the Requirement ID column
contains the appropriate Jira key.
- Line 187: The Dependencies table row currently marked "N/A" is inconsistent
with the Risks section which cites a dependency on allowing multi-cpu
architecture in the openshift-virtualization-tests repo (see Risks entry
referencing the PR); update the Dependencies cell for "Dependencies" to
explicitly list the openshift-virtualization-tests change (include the PR
reference or link and the owning team) or, if it truly isn't required, add a
brief justification referencing the Risks line so the table and Risks section
match (edit the table row labeled "Dependencies" to replace "N/A" with the
dependency details or the justification).
- Around line 160-169: The out-of-scope table rows (e.g., entries under the
"Non-Goal" column such as "Testing with s390x architecture", "Templates creation
& utilization", "Imports & datasource new API", etc.) lack stakeholder sign-off
placeholders and therefore remain flagged as risks; contact the responsible
PMs/leads for each listed out-of-scope item, collect their name and sign-off
date, and update each corresponding "[ ] Name/Date" cell with the approver's
name and date (or explicitly document an escalated mitigation note if a sign-off
cannot be obtained) so the table complies with the instructions on lines
referencing stakeholder agreement.
- Line 184: The "Regression Testing" table entry is inconsistent with the NFRs:
update the table row for "Regression Testing" (the cell currently "N/A") to "Y"
and add a brief strategy note referencing the NFR text "Regression: Run IUO T2
tests (must-gather, nodeplacement, golden images tests in particular)" so it
clearly states that IUO T2 tests will be executed as the regression strategy;
alternatively, if regression is intentionally covered elsewhere, replace "N/A"
with a one-line pointer to that section and cite the specific NFR text to avoid
confusion.
🧹 Nitpick comments (1)
stps/sig-iuo/golden_image_multiarch_support.md (1)
296-300: Sign-off placeholders need completion before finalization.The sign-off section contains only placeholder text. While this is expected for a draft document (status "Draft" at line 15), please ensure this section is completed with actual reviewer and approver names before moving to "Final" status.
📜 Review details
Configuration used: Organization UI
Review profile: CHILL
Plan: Pro
📒 Files selected for processing (1)
stps/sig-iuo/golden_image_multiarch_support.md
🧰 Additional context used
🧠 Learnings (1)
📚 Learning: 2026-01-08T17:18:15.313Z
Learnt from: yossisegev
Repo: RedHatQE/openshift-virtualization-tests-design-docs PR: 7
File: stps/sig-network/ip-request-stp.md:0-0
Timestamp: 2026-01-08T17:18:15.313Z
Learning: In the repository RedHatQE/openshift-virtualization-tests-design-docs, the preferred style is "3rd party" without hyphenation, not "third-party".
Applied to files:
stps/sig-iuo/golden_image_multiarch_support.md
🪛 LanguageTool
stps/sig-iuo/golden_image_multiarch_support.md
[style] ~53-~53: You have already used this phrasing in nearby sentences. Consider replacing it to add variety to your writing.
Context: ...usters.
2. As a cluster admin, I want to define custom golden images with multi-...
(REP_WANT_TO_VB)
[style] ~278-~278: You have already used this phrasing in nearby sentences. Consider replacing it to add variety to your writing.
Context: ... | As a cluster admin, I want to define custom golden images with multi-...
(REP_WANT_TO_VB)
[style] ~279-~279: You have already used this phrasing in nearby sentences. Consider replacing it to add variety to your writing.
Context: ... | As a VM creator/cluster admin, I want to create VMs / custom golden images for s...
(REP_WANT_TO_VB)
[style] ~280-~280: You have already used this phrasing in nearby sentences. Consider replacing it to add variety to your writing.
Context: ... | As a cluster admin, I want to define custom golden images for specifi...
(REP_WANT_TO_VB)
[style] ~283-~283: You have already used this phrasing in nearby sentences. Consider replacing it to add variety to your writing.
Context: ... | As a cluster admin, I want to define custom golden images with multi-...
(REP_WANT_TO_VB)
[style] ~287-~287: You have already used this phrasing in nearby sentences. Consider replacing it to add variety to your writing.
Context: ... | As a VM creator/cluster admin, I want to create VMs / custom golden images for s...
(REP_WANT_TO_VB)
[style] ~288-~288: You have already used this phrasing in nearby sentences. Consider replacing it to add variety to your writing.
Context: ... | As a VM creator/cluster admin, I want to create VMs / define custom golden image...
(REP_WANT_TO_VB)
🔇 Additional comments (4)
stps/sig-iuo/golden_image_multiarch_support.md (4)
237-246: Multiple unresolved risks near code freeze.The timeline risk (line 239) indicates "Code-Freeze this week," but the risks table shows most items with status "[ ]" (unresolved), including test environment setup (CNV-73894), dependencies, and a blocker bug (CNV-75762).
Consider updating this section with:
- Current status of each risk item
- Updated mitigation strategies or acceptance that some items will carry into post-GA
- Clear ownership assignments for risk resolution
5-16: Well-structured metadata and clear feature description.The metadata section provides comprehensive tracking information with proper enhancement and Jira references. The feature overview (lines 29-35) clearly explains the coordination between HCO, SSP, and CDI components, and the API extensions table (line 71) documents specific field changes across all affected components.
This level of detail provides excellent context for reviewers and future test maintainers.
Also applies to: 29-35, 71-71
125-145: Testing goals are well-defined and properly prioritized.The functional, monitoring, backward compatibility, and upgrade goals are:
- Specific and measurable
- Properly prioritized (P0 for blocking issues, P1 for important but non-blocking)
- Aligned with the acceptance criteria from Section I (lines 56-56)
- Cover both positive and negative test scenarios
This provides a solid foundation for test implementation.
188-188: Excellent cross-integration scope breakdown.The Cross Integrations row provides clear ownership assignments across IUO, SSP, Storage, and Virt teams with specific testing responsibilities. This clarity is essential for coordinating multi-team features and avoiding coverage gaps.
The explicit callout of monitoring and upgrade testing responsibilities for each component is particularly valuable.
There was a problem hiding this comment.
Actionable comments posted: 4
🤖 Fix all issues with AI agents
In `@stps/sig-iuo/golden_image_multiarch_support.md`:
- Line 173: Typo in the markdown table cell: change the string
"'defaultCPUModel' intergations" to "'defaultCPUModel' integrations" so the word
"integrations" is spelled correctly in the table row referencing the Virt
team/CNV-26818 entry.
- Line 195: Fix the typo in the table cell that reads "Testing enviroment AWS
cluster" by changing "enviroment" to "environment" so the cell reads "Testing
environment AWS cluster"; locate the string under the "Cloud Testing" row in the
markdown table (the cell containing "Testing enviroment AWS cluster") and update
it accordingly.
- Line 34: Update the paragraph describing multi-arch golden image support:
correct the phrase “Not earlier then 4.23” to “not earlier than 4.23” and split
the long run-on sentence into two sentences for clarity; keep the feature gate
reference `enableMultiArchBootImageImport` and the components HCO, SSP, and CDI
in the revised text so the intent remains clear while improving grammar and
readability.
- Line 246: Update the markdown table cell in the row containing "Test Coverage"
where the checkbox is written as "[]"; change that token to the correctly spaced
markdown checkbox "[ ]" so the table shows an unchecked box (i.e., replace "[]
" with "[ ]" in the cell content).
🧹 Nitpick comments (1)
stps/sig-iuo/golden_image_multiarch_support.md (1)
222-222: Table content mismatch: “Test Framework” should list a framework, not a cluster type.If no new framework is needed, use “N/A” or leave blank per the guidance in the section.
Signed-off-by: Harel Meir <hmeir@redhat.com>
…ifecycle STP for enableMultiArchBootImageImport feature testing on heterogeneous clusters. Covers DataSource lifecycle, architecture labeling, duplicate prevention, and cleanup validation. Related: VIRTSTRAT-494 Parent STP: RedHatQE#12 Signed-off-by: Geetika Kapoor <gkapoor@redhat.com>
…ifecycle STP for enableMultiArchBootImageImport feature testing on heterogeneous clusters. Covers DataSource lifecycle, architecture labeling, duplicate prevention, and cleanup validation. Related: VIRTSTRAT-494 Parent STP: RedHatQE#12 Signed-off-by: Geetika Kapoor <gkapoor@redhat.com>
Signed-off-by: Harel Meir <hmeir@redhat.com>
…mation Signed-off-by: Harel Meir <hmeir@redhat.com>
| - [sig-iuo representative / @nunnatsa @rllobilo @OhadRevah @albarker-rh] | ||
| - [sig-storage representative] | ||
| - [sig-virt representative] | ||
| - [sig-infra representative] |
There was a problem hiding this comment.
do we want UI representation here ?
| | | Functional validation post-upgrade when FG enabled by default | Verify functional tests pass post-upgrade to version with Multiarch FG enabled by default | Tier 2 | P1 | | ||
| | | Custom golden images without arch annotation remain functional | Verify custom golden images without arch annotation remain functional | Tier 2 | P0 | | ||
|
|
||
| --- |
There was a problem hiding this comment.
should we have an exit criteria?it shows what is a Done criteria looks like. I have in my STP incase you like to have a look.
There was a problem hiding this comment.
Its pertty much the same as acceptece critira isn't it?
There was a problem hiding this comment.
Based on my understanding ,acceptance criteria tell you if the feature works correctly, exit criteria tell what's the criteria you set for "done" testing . You could pass all your acceptance criteria but still have gaps like you only ran T1 and never got to T2 or there's an open blocker with no agreed fixed dates. Exit criteria is basically team's checklist before signing off feature from QE side.
|
|
||
| | Requirement ID | Requirement Summary | Test Scenario(s) | Tier | Priority | | ||
| |:--------------------------------------------------------|:--------------------------------------------------------------------------|:----------------------------------------------------------------------------------------------------------------------------------------------------------------------------|:-------|:---------| | ||
| | [CNV-67900](https://issues.redhat.com/browse/CNV-67900) | HCO detects and reports node architectures | Verify HCO monitors node architectures correctly, including on node addition/removal | Tier 1 | P0 | |
There was a problem hiding this comment.
should we group tests based on their nature and what all tests fits together? maybe such tests can go under same class/file? also improves readability
- Alerts & Metrics
- arch detection and ...
- etc
Signed-off-by: Harel Meir <hmeir@redhat.com>
|
/lgtm |
|
|
||
| **Regression Goals**: | ||
|
|
||
| Regression testing ensures that existing functionality continues to work correctly on multiarch clusters after the introduction of multiarch support. Each participating SIG must run its Tier 1 (functional) and Tier 2 (end-to-end) test suites on multiarch clusters with both CPU architectures to confirm no regressions are introduced. |
There was a problem hiding this comment.
Since its a multiarch cluster - with FG enabled.
Otherwise VM scheduling,golden images, templates etc wont work as expected.
Our test should be dynamic.
There was a problem hiding this comment.
ok. I would add this on the description. As a regression goal I would assume that this is for testing that nothing is broken when the FG is disabled.
| | | Arch-specific resources created and ready to use | Verify arch-specific resources created for supported architectures, named with architecture suffix, and are ready to use | Tier 2 | P0 | | ||
| | | Fail status for golden images with only unsupported architectures | Verify HCO `dataImportCronTemplates` status shows failure for dataImportCronTemplate annotated only with unsupported architectures | Tier 1 | P1 | | ||
| | [CNV-67900](https://issues.redhat.com/browse/CNV-67900) | Alert and metric for golden image with unsupported architecture | Verify `HCOGoldenImageWithNoSupportedArchitecture` alert fires and `kubevirt_hco_dataimportcrontemplate_with_supported_architectures` metric reports the appropriate value | Tier 2 | P1 | | ||
| | | Alert and metric for disabled Multiarch FG on multi-arch cluster | Verify `HCOMultiArchGoldenImagesDisabled` alert fires and `kubevirt_hco_multi_arch_boot_images_enabled` metric reports the appropriate value | Tier 2 | P1 | |
There was a problem hiding this comment.
is there a way to clean the alert? Just wondering what would happen in that case, if the system will reconcile and trigger the alert again.
There was a problem hiding this comment.
The alert is cleaned by prometheus.
Once the expression is no longer True, its getting cleaned(after few min usually).
There was a problem hiding this comment.
is the test going to enable the FG and check that that the alert is gone?
|
Hi, I still don't see a human readable user stories stating what a usual CNV personas are expected to see. I know a lot use cases is covered, but I am missing this level of description of the tests: |
|
|
||
| | Field | Details | | ||
| |:-----------------------|:---------------------------------------------------------------------------------------------------------------------------------| | ||
| | **Enhancement(s)** | [dic-on-heterogeneous-cluster](https://github.com/kubevirt/enhancements/tree/main/veps/sig-storage/dic-on-heterogeneous-cluster) | |
There was a problem hiding this comment.
This is a storage VEP, isn't it?
Are you sure it's the correct one?
| - **[P0]** Verify VMs created from arch-specific templates run on matching architecture nodes (sig-infra). | ||
| - **[P0]** Verify CDI imports correct architecture-specific images via `platform.architecture` ([sig-storage](https://issues.redhat.com/browse/CNV-76732)). | ||
| - **[P0]** Verify VMs scheduled only on nodes matching their CPU architecture ([sig-virt](https://issues.redhat.com/browse/CNV-26818)). | ||
| - **[P0]** Verify VM migration between same-architecture nodes works correctly (sig-virt). |
There was a problem hiding this comment.
Are we sure about that? From what I understood after speaking with Dan, migration is not planned to be supported at all in heterogeneous clusters, regardless of whether the migration is attempted between equally-arched nodes.
Please validate this pont.
| | Untestable Aspects | N/A | N/A | [X] | | ||
| | Resource Constraints | MultiArch cluster available only for 12 hours; limited number of AWS clusters available | Test automation on HA cluster first, final verification on MultiArch. Verify that DevOps are investigating increasing the number of available AWS clusters. | [ ] | | ||
| | Dependencies | Allowing multi-cpu architecture on openshift-virtualization-tests | Review the [PR](https://github.com/RedHatQE/openshift-virtualization-tests/pull/3147) whenever its ready to review. | [ ] | | ||
| | Blocker Bug for legacy DataSources | [CNV-75762](https://issues.redhat.com/browse/CNV-75762) | on POST - Storage QE to verify | [ ] | |
There was a problem hiding this comment.
This bug is already marked as verified, you might want to update this.
12 participants
STP Metadata
VEP issue:https://github.com/kubevirt/enhancements/blob/main/veps/sig-storage/dic-on-heterogeneous-cluster/dic-on-heterogeneous-cluster.md
What this PR does
Multiarch golden image support HCO
Special notes for your reviewer
Summary by CodeRabbit