Skip to content

fix(build): rpms lock repo file location#2211

Merged
jdobes merged 1 commit intoRedHatInsights:masterfrom
vkrizan:fix-rpm-repo
Feb 12, 2026
Merged

fix(build): rpms lock repo file location#2211
jdobes merged 1 commit intoRedHatInsights:masterfrom
vkrizan:fix-rpm-repo

Conversation

@vkrizan
Copy link
Collaborator

@vkrizan vkrizan commented Feb 12, 2026

Secure Coding Practices Checklist GitHub Link

Secure Coding Checklist

  • Input Validation
  • Output Encoding
  • Authentication and Password Management
  • Session Management
  • Access Control
  • Cryptographic Practices
  • Error Handling and Logging
  • Data Protection
  • Communication Security
  • System Configuration
  • Database Security
  • File Management
  • Memory Management
  • General Coding Practices

Summary by Sourcery

Build:

  • Point RPM content origin repofile to .hermetic_builds/redhat.repo instead of the previous relative path.

@vkrizan vkrizan requested a review from jdobes February 12, 2026 15:06
@sourcery-ai
Copy link

sourcery-ai bot commented Feb 12, 2026

Reviewer's guide (collapsed on small PRs)

Reviewer's Guide

Updates the RPM build configuration to use a locked, hermetic repository file path for content origin, improving build reproducibility and security.

Flow diagram for RPM build using hermetic repo file

flowchart TD
  A[Start RPM build] --> B[Load rpms_in_yaml]
  B --> C[Read contentOrigin_repofiles]
  C --> D[Resolve .hermetic_builds/redhat_repo]
  D --> E[Configure RPM builder with locked repo]
  E --> F[Fetch packages from configured repo]
  F --> G[Build RPM artifacts]
  G --> H[Finish RPM build]
Loading

File-Level Changes

Change Details Files
Point RPM content origin repo configuration at the hermetic, locked repo file path.
  • Change the repofiles entry to reference .hermetic_builds/redhat.repo instead of the local ./redhat.repo
  • Keep existing package list, architectures, and moduleEnable configuration unchanged
rpms.in.yaml

Tips and commands

Interacting with Sourcery

  • Trigger a new review: Comment @sourcery-ai review on the pull request.
  • Continue discussions: Reply directly to Sourcery's review comments.
  • Generate a GitHub issue from a review comment: Ask Sourcery to create an
    issue from a review comment by replying to it. You can also reply to a
    review comment with @sourcery-ai issue to create an issue from it.
  • Generate a pull request title: Write @sourcery-ai anywhere in the pull
    request title to generate a title at any time. You can also comment
    @sourcery-ai title on the pull request to (re-)generate the title at any time.
  • Generate a pull request summary: Write @sourcery-ai summary anywhere in
    the pull request body to generate a PR summary at any time exactly where you
    want it. You can also comment @sourcery-ai summary on the pull request to
    (re-)generate the summary at any time.
  • Generate reviewer's guide: Comment @sourcery-ai guide on the pull
    request to (re-)generate the reviewer's guide at any time.
  • Resolve all Sourcery comments: Comment @sourcery-ai resolve on the
    pull request to resolve all Sourcery comments. Useful if you've already
    addressed all the comments and don't want to see them anymore.
  • Dismiss all Sourcery reviews: Comment @sourcery-ai dismiss on the pull
    request to dismiss all existing Sourcery reviews. Especially useful if you
    want to start fresh with a new review - don't forget to comment
    @sourcery-ai review to trigger a new review!

Customizing Your Experience

Access your dashboard to:

  • Enable or disable review features such as the Sourcery-generated pull request
    summary, the reviewer's guide, and others.
  • Change the review language.
  • Add, remove or edit custom review instructions.
  • Adjust other review settings.

Getting Help

@github-actions
Copy link
Contributor

SC Environment Impact Assessment

Overall Impact:NONE

No SC Environment-specific impacts detected in this PR.

What was checked

This PR was automatically scanned for:

  • Database migrations
  • ClowdApp configuration changes
  • Kessel integration changes
  • AWS service integrations (S3, RDS, ElastiCache)
  • Kafka topic changes
  • Secrets management changes
  • External dependencies

Copy link

@sourcery-ai sourcery-ai bot left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Hey - I've reviewed your changes and they look great!


Sourcery is free for open source - if you like our reviews please consider sharing them ✨
Help me be more useful! Please click 👍 or 👎 on each comment and I'll use the feedback to improve your reviews.

@jdobes jdobes merged commit fd3ab19 into RedHatInsights:master Feb 12, 2026
7 of 11 checks passed
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

2 participants