Skip to content

Conversation

@joanise
Copy link
Member

@joanise joanise commented Dec 19, 2025

PR Goal?

Marc suggested the small version label at the bottom of the page should be hyperlinked to the project. I like the idea.

So...

In the Studio-Web footer and the Web-Component settings footer, @readalongs/studio-web version: 1.6.2 and @readalongs/web-component version: 1.6.2 become @readalongs/studio-web 1.6.2 and @readalongs/web-component 1.6.2 both hyperlinked to https://github.com/ReadAlongs/Studio-Web

Fixes?

The lack of a connection back from the app to the project page or source code

Feedback sought?

Are you OK with the concept?

Is https://github.com/ReadAlongs/Studio-Web the right thing to link to?

Alternatives I can think of:

Priority?

low

Tests added?

no

How to test?

In the PR preview:

  • look at/click on the footer of the studio-web app
  • enter data and got to step 2
  • click on the gear icon to look at/click on the footer of the My preferences panel

Confidence?

high for the code

medium for the choice of hyperlinks

Version change?

no

@semanticdiff-com
Copy link

semanticdiff-com bot commented Dec 19, 2025

Review changes with  SemanticDiff

Changed Files
File Status
  packages/studio-web/src/app/app.component.html  43% smaller
  packages/web-component/src/components/read-along-component/read-along.tsx  24% smaller

@joanise joanise changed the title feat: hyperlink the app name in the footer feat: hyperlink the app name in the footers Dec 19, 2025
@github-actions
Copy link
Contributor

PR Preview Action v1.6.3

🚀 View preview at
https://ReadAlongs.github.io/Studio-Web/pr-preview/pr-497/

Built to branch gh-pages at 2025-12-19 20:35 UTC.
Preview will be ready when the GitHub Pages deployment is complete.

Copy link
Collaborator

@marctessier marctessier left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

I like this :-) I tried all 3 languages ... all pointing to the website when I click on it .

[@readalongs/studio-web 1.6.2](https://github.com/ReadAlongs/Studio-Web)

<a
href="https://github.com/ReadAlongs/Studio-Web"
target="_blank"
rel="noreferrer"
Copy link
Collaborator

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

noopener would make sense here also.

Copy link
Member Author

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

good point

@sergeleger
Copy link
Collaborator

sergeleger commented Dec 22, 2025

This is an odd color for the link. (odd: in that it is not really used anywhere else). Looks like it's the default SCSS color?

image

@joanise
Copy link
Member Author

joanise commented Dec 23, 2025

This is an odd color for the link.

Yeah, it just came up that way, not my deliberate choice. I thought it was fine so I didn't try to patch it, do you think I should make it standard hyperlink blue?

@deltork
Copy link
Collaborator

deltork commented Dec 24, 2025

This is an odd color for the link.

Yeah, it just came up that way, not my deliberate choice. I thought it was fine so I didn't try to patch it, do you think I should make it standard hyperlink blue?

Yes, it needs to match the rest of the site (links in the nav)

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

5 participants