-
Notifications
You must be signed in to change notification settings - Fork 11
feat: hyperlink the app name in the footers #497
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
base: main
Are you sure you want to change the base?
Conversation
Changed Files
|
|
marctessier
left a comment
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
I like this :-) I tried all 3 languages ... all pointing to the website when I click on it .
[@readalongs/studio-web 1.6.2](https://github.com/ReadAlongs/Studio-Web)
| <a | ||
| href="https://github.com/ReadAlongs/Studio-Web" | ||
| target="_blank" | ||
| rel="noreferrer" |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
noopener would make sense here also.
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
good point
Yeah, it just came up that way, not my deliberate choice. I thought it was fine so I didn't try to patch it, do you think I should make it standard hyperlink blue? |
Yes, it needs to match the rest of the site (links in the nav) |

PR Goal?
Marc suggested the small version label at the bottom of the page should be hyperlinked to the project. I like the idea.
So...
In the Studio-Web footer and the Web-Component settings footer,
@readalongs/studio-web version: 1.6.2and@readalongs/web-component version: 1.6.2become@readalongs/studio-web 1.6.2and@readalongs/web-component 1.6.2both hyperlinked to https://github.com/ReadAlongs/Studio-WebFixes?
The lack of a connection back from the app to the project page or source code
Feedback sought?
Are you OK with the concept?
Is https://github.com/ReadAlongs/Studio-Web the right thing to link to?
Alternatives I can think of:
Priority?
low
Tests added?
no
How to test?
In the PR preview:
Confidence?
high for the code
medium for the choice of hyperlinks
Version change?
no