Fix: missing CFBundleShortVersionString#2696
Open
ori-hime wants to merge 1 commit intoReactiveX:mainfrom
Open
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
1 participant
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
This PR fixes #2687.
The issue where CFBundleShortVersionString was missing has been resolved.
The root cause was that the project's build configuration was missing the
baseConfigurationReferencetoVersion.xcconfig.This PR adds the reference to all build configurations for consistency.
(In my environment, running tests targeting the iOS 26.2 simulator was difficult, so I ran all-tests.sh on iOS 26.0.)
A small suggestion for future releases:
I noticed that the
RX_VERSIONinVersion.xcconfigwas not updated to6.10.2when the6.10.2tag was released.This PR updates the version to
6.10.2to match the latest tag.To prevent this from happening again, it would be great if you could ensure that
Version.xcconfigis updated as part of the official release process for future versions (like6.10.3).Thank you for your consideration and for maintaining this great library!