Nav entry modularization#473
Merged
ychescale9 merged 10 commits intomainfrom Dec 30, 2025
Merged
Conversation
…vider to `impl`, move nav key and shared transition keys to `api `.
… element keys definitions.
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
1 participant
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Split feature modules that are navigation destinations to
:apiand:impl:apimodules have Nav key definition and shared transition keys / key generation functionsimplmodules has an extension function onEntryProviderScopeas the feature's entry point, along with everything else before the split:feature:<foo>:implmodules can depend on:feature:<foo>:apito handle navigation events internally instead of propagating up to the:appmodule to handle all nav events for all features.