feat: Add mount, unmount and isMounted to RootInstaller#125
Open
feat: Add mount, unmount and isMounted to RootInstaller#125
Conversation
oSumAtrIX
reviewed
Apr 5, 2026
| ) | ||
| } | ||
|
|
||
| suspend fun mount(packageName: String): RootInstallerResult { |
Member
There was a problem hiding this comment.
Granular mount and unmount control should never be needed. Callsite should ever need to either install, or uninstall, which the current APIs already provide.
Member
Author
There was a problem hiding this comment.
I have seen a few users use the control to their advantage, most recent one I saw was where their mounted app was crashing, instead of repatching they unmounted, updated the unpatched app then remounted
This could be achieved by proxy by switching to magisk modules, users can simply disable or enable the module if they want
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
No description provided.