Skip to content

Conversation

@MichaelChirico
Copy link
Member

Minor change for consistency.

This could have been part of #7260 -- there, gettext() was used since the message would be passed to either stop() or warning(); now, it's always passed to stop(), so we don't need to separate into two steps.

@codecov
Copy link

codecov bot commented Dec 26, 2025

Codecov Report

✅ All modified and coverable lines are covered by tests.
✅ Project coverage is 98.97%. Comparing base (e26cfb3) to head (ffc0925).
⚠️ Report is 1 commits behind head on master.

Additional details and impacted files
@@            Coverage Diff             @@
##           master    #7528      +/-   ##
==========================================
- Coverage   98.97%   98.97%   -0.01%     
==========================================
  Files          87       87              
  Lines       16739    16738       -1     
==========================================
- Hits        16567    16566       -1     
  Misses        172      172              

☔ View full report in Codecov by Sentry.
📢 Have feedback on the report? Share it here.

🚀 New features to boost your workflow:
  • ❄️ Test Analytics: Detect flaky tests, report on failures, and find test suite problems.

@github-actions
Copy link

github-actions bot commented Dec 26, 2025

No obvious timing issues in HEAD=rm-gettext
Comparison Plot

Generated via commit ffc0925

Download link for the artifact containing the test results: ↓ atime-results.zip

Task Duration
R setup and installing dependencies 4 minutes and 42 seconds
Installing different package versions 10 minutes and 46 seconds
Running and plotting the test cases 3 minutes and 25 seconds

@ben-schwen ben-schwen merged commit dd8caaa into master Dec 26, 2025
12 checks passed
@ben-schwen
Copy link
Member

TY!

@ben-schwen ben-schwen deleted the rm-gettext branch December 26, 2025 18:50
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

2 participants