Add dynamic bucket support #323
Merged
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Collaborator
|
lgtm. Thank you. |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Hello! I'm a dev of the mod The Undergarden and recently I added a dynamic bucket item that can pick up any modded bucket-able entity, block, or fluid. The only thing that needs to be provided from your end to make this feature work exactly as intended is a texture of the bucket content, as I don't feel comfortable packaging other mod's assets into our mod. (The textures are simply your bucket items with the bucket part stripped out)
This also adds compatibility with the mod BucketLib as I intentionally use the same directory they look for to prevent duplicate textures in multiple places, while also adding automatic support to my stuff in places they already made PRs :)