-
Notifications
You must be signed in to change notification settings - Fork 17
lang/en_us.json cleanup #310
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Open
AriaElidove
wants to merge
15
commits into
RazorDevs:1.21.1-1.1
Choose a base branch
from
AriaElidove:Cleanup
base: 1.21.1-1.1
Could not load branches
Branch not found: {{ refName }}
Loading
Could not load tags
Nothing to show
Loading
Are you sure you want to change the base?
Some commits from the old base branch may be removed from the timeline,
and old review comments may become outdated.
Open
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
darksonic300
requested changes
Sep 20, 2025
Collaborator
darksonic300
left a comment
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
mostly looks good. The only things I'd change would be the removal of all the Highstone stuff and other things related to Oratie, Agate and Abidium ores. These were decided to ultimately not be implemented and their entries are to be removed.
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Should be the last time I touch this in a long time! Here's all that's different:
Re-implements Update en_us.json #306 (Lore entry fixes)
Fixes Smithing Table GUI (Wrong materials requested)
Minor writing issues
Implements new lore
-- Glowing Vines
-- Tall Glowing Grass
-- Polished Aseterite Wall
-- Polished Clorite Wall
-- Sunroot Hanger
-- Remedy Potion Variants
-- Arrow of Remedy
Re-sort for non-main DA implements
-- Dungeon Blocks without Lore
-- Experimental 1.2
-- Experimental 1.2 without Lore
-- Mod-Compat - Aether: Redux
-- Mod-Compat - Aether: Genesis
-- Mod-Compat - Aether: Lost Content
-- CHAOS >:3c
Cleanup of Redundant/Unused entries
-- Requested cleanup (Highstone & Related Ores)
-- Creative Tabs
-- Slider Ring GUI/Subtitles
-- Frosted Holystone variants
-- Aerglow Grass variants
-- Old Stratus entries
-- Old Ascended Quark-based entries