Skip to content

feat(netcore): add device guid param#29

Open
sakkshm26 wants to merge 3 commits intomainfrom
saksham/lin-12-netcore-integration
Open

feat(netcore): add device guid param#29
sakkshm26 wants to merge 3 commits intomainfrom
saksham/lin-12-netcore-integration

Conversation

@sakkshm26
Copy link
Collaborator

@sakkshm26 sakkshm26 commented Mar 21, 2026

Summary by CodeRabbit

  • New Features
    • Added support for capturing Netcore device GUID in user data collection.

@coderabbitai
Copy link

coderabbitai bot commented Mar 21, 2026

Warning

Rate limit exceeded

@sakkshm26 has exceeded the limit for the number of commits that can be reviewed per hour. Please wait 10 minutes and 49 seconds before requesting another review.

⌛ How to resolve this issue?

After the wait time has elapsed, a review can be triggered using the @coderabbitai review command as a PR comment. Alternatively, push new commits to this PR.

We recommend that you space out your commits to avoid hitting the rate limit.

🚦 How do rate limits work?

CodeRabbit enforces hourly rate limits for each developer per organization.

Our paid plans have higher rate limits than the trial, open-source and free plans. In all cases, we re-allow further reviews after a brief timeout.

Please see our FAQ for further information.

ℹ️ Review info
⚙️ Run configuration

Configuration used: defaults

Review profile: CHILL

Plan: Pro

Run ID: c817dc3a-6e78-462e-ae60-c37ed5e371c5

📥 Commits

Reviewing files that changed from the base of the PR and between ca8edd1 and 3a73c21.

📒 Files selected for processing (5)
  • CHANGELOG.md
  • android/build.gradle
  • ios/linkrunner.podspec
  • lib/linkrunner.dart
  • pubspec.yaml
📝 Walkthrough

Walkthrough

This PR adds support for capturing the Netcore device GUID via a new netcoreDeviceGuid field across the Flutter SDK, updates the package version to 3.71.0, and bumps native dependency versions for iOS and Android platforms.

Changes

Cohort / File(s) Summary
Version and Dependency Updates
CHANGELOG.md, pubspec.yaml, lib/linkrunner.dart, android/build.gradle, ios/linkrunner.podspec
Updated package version from 3.7.0 to 3.71.0 and bumped native SDK dependencies: io.linkrunner:android-sdk to 3.61.0 and LinkrunnerKit to 3.81.0.
Data Model Enhancement
lib/models/lr_user_data.dart
Added optional netcoreDeviceGuid field to LRUserData class with constructor parameter and conditional JSON serialization as netcore_device_guid.
Platform Integration
android/src/main/kotlin/io/linkrunner/flutter/LinkrunnerPlugin.kt, ios/Classes/SwiftLinkrunnerPlugin.swift
Mapped userData["netcore_device_guid"] to native UserDataRequest.netcoreDeviceGuid (Android) and UserData.netcoreDeviceGuid (iOS) in signup and setUserData paths.

Estimated code review effort

🎯 2 (Simple) | ⏱️ ~10 minutes

Possibly related PRs

Suggested reviewers

  • Shofiya2003

Poem

🐰 A field hops through from Dart to native ground,
Through Android and iOS it makes its round,
NetcoreDeviceGuid now finds its way,
Version 3.71 brings the GUID to play! ✨

🚥 Pre-merge checks | ✅ 2 | ❌ 1

❌ Failed checks (1 warning)

Check name Status Explanation Resolution
Docstring Coverage ⚠️ Warning Docstring coverage is 0.00% which is insufficient. The required threshold is 80.00%. Write docstrings for the functions missing them to satisfy the coverage threshold.
✅ Passed checks (2 passed)
Check name Status Explanation
Description Check ✅ Passed Check skipped - CodeRabbit’s high-level summary is enabled.
Title check ✅ Passed The title 'feat(netcore): add device guid param' clearly and specifically describes the main change: adding support for a Netcore device GUID parameter across multiple platform implementations.

✏️ Tip: You can configure your own custom pre-merge checks in the settings.

✨ Finishing Touches
🧪 Generate unit tests (beta)
  • Create PR with unit tests
  • Commit unit tests in branch saksham/lin-12-netcore-integration

Thanks for using CodeRabbit! It's free for OSS, and your support helps us grow. If you like it, consider giving us a shout-out.

❤️ Share

Comment @coderabbitai help to get the list of available commands and usage tips.

Copy link

@coderabbitai coderabbitai bot left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Actionable comments posted: 1

🤖 Prompt for all review comments with AI agents
Verify each finding against the current code and only fix it if needed.

Inline comments:
In `@android/build.gradle`:
- Line 51: The declared dependency implementation
'io.linkrunner:android-sdk:3.61.0' is invalid and will break the build; update
that declaration to a published version (for example change the version to 3.1.1
or another confirmed published release) in the android/build.gradle file so the
Gradle build can resolve the artifact; locate the implementation line containing
io.linkrunner:android-sdk and replace the version token with the correct
published version for your release.

ℹ️ Review info
⚙️ Run configuration

Configuration used: defaults

Review profile: CHILL

Plan: Pro

Run ID: 5aef8fb0-dd11-4417-89da-7c554b2eeee5

📥 Commits

Reviewing files that changed from the base of the PR and between 6d53e61 and ca8edd1.

📒 Files selected for processing (8)
  • CHANGELOG.md
  • android/build.gradle
  • android/src/main/kotlin/io/linkrunner/flutter/LinkrunnerPlugin.kt
  • ios/Classes/SwiftLinkrunnerPlugin.swift
  • ios/linkrunner.podspec
  • lib/linkrunner.dart
  • lib/models/lr_user_data.dart
  • pubspec.yaml

@sakkshm26 sakkshm26 requested a review from Shofiya2003 March 23, 2026 07:35
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

1 participant