Conversation
They're not needed now that we're using intervals, which have their own hull function.
The old method was unused now that everything's being changed to take IntervalBoxes, so I decided this was more useful. Now, it returns a 3-dimensional array obtained from calling the individual method on each element of the vector, effectively concatenating the automatically-vectorized version on the third dimension.
This order, with each column as a state vector, matches functions like lsim from ControlSystems, and offers better cache behavior with Julia's matrix ordering. It also matches many uses of the function, which immediately transposed its return value.
|
Seems like this is hanging on the |
|
I went ahead and fixed the safety_margin code so it at least doesn't cause an exception. Whatever bug existed before may still persist, but otherwise I think this is ready to merge. Seems like CI is having some issues right now, and we probably still have documentation to update, so I'll give it a bit. |
|
Actually, no! This whole branch has been obsoleted by IntervalArithmetic 0.22, which removed the IntervalBox type in favor of simply using vectors of intervals. I'll have to rewrite this to match the new API. |
2 participants
This PR closes #8 by rewriting the package to use IntervalArithmetic.jl for intervals instead of matrices. In addition to bringing semantic types, this actually improves performance by around 2–3× for
bounded_runs_iter.There are still a few changes I'd like to do in this branch prior to merging:
safety_marginparameter (needs testing)evolfunction family to takeIntervalBoxes in addition to vectorsevolfamilyAdded bonus: I also added a ULS method for overapproximating reachable sets, like in the paper. It's really simple to implement, it turns out.