Skip to content

Commit 5fb9d71

Browse files
committed
Consolidate school import abilities into one method
1 parent 03492f7 commit 5fb9d71

File tree

1 file changed

+9
-4
lines changed

1 file changed

+9
-4
lines changed

app/models/ability.rb

Lines changed: 9 additions & 4 deletions
Original file line numberDiff line numberDiff line change
@@ -120,19 +120,24 @@ def define_school_student_abilities(user:, school:)
120120
can(%i[show_finished set_finished show_status unsubmit submit], SchoolProject, project: { user_id: user.id, lesson_id: nil }, school_id: school.id)
121121
end
122122

123-
def define_editor_admin_abilities(user)
124-
return unless user&.admin?
123+
def define_school_import_abilities(user)
124+
return unless user&.admin? || user&.experience_cs_admin?
125125

126126
can :import, School
127127
can :read, :school_import_job
128128
end
129129

130+
def define_editor_admin_abilities(user)
131+
return unless user&.admin?
132+
133+
define_school_import_abilities(user)
134+
end
135+
130136
def define_experience_cs_admin_abilities(user)
131137
return unless user&.experience_cs_admin?
132138

133139
can %i[read create update destroy], Project, user_id: nil
134-
can :import, School
135-
can :read, :school_import_job
140+
define_school_import_abilities(user)
136141
end
137142

138143
def school_teacher_can_manage_lesson?(user:, school:, lesson:)

0 commit comments

Comments
 (0)