Modify check on owner to fail if owner has any role in any other school.

Author: fspeirs

app/jobs/school_import_job.rb

@@ -50,13 +50,14 @@ def import_school(school_data)
       return
     end
 
-    # Check if this owner already has a school as creator
-    existing_school = School.find_by(creator_id: owner[:id])
-    if existing_school
+    # Check if this owner already has any role in any school
+    existing_role = Role.find_by(user_id: owner[:id])
+    if existing_role
+      existing_school = existing_role.school
       @results[:failed] << {
         name: school_data[:name],
-        error_code: SchoolImportError::CODES[:owner_already_creator],
-        error: "Owner #{school_data[:owner_email]} is already the creator of school '#{existing_school.name}'",
+        error_code: SchoolImportError::CODES[:owner_has_existing_role],
+        error: "Owner #{school_data[:owner_email]} already has a role in school '#{existing_school.name}'",
         owner_email: school_data[:owner_email],
         existing_school_id: existing_school.id
       }

app/models/school_import_error.rb

@@ -7,6 +7,7 @@ module SchoolImportError
     csv_validation_failed: 'CSV_VALIDATION_FAILED',
     owner_not_found: 'OWNER_NOT_FOUND',
     owner_already_creator: 'OWNER_ALREADY_CREATOR',
+    owner_has_existing_role: 'OWNER_HAS_EXISTING_ROLE',
     duplicate_owner_email: 'DUPLICATE_OWNER_EMAIL',
     school_validation_failed: 'SCHOOL_VALIDATION_FAILED',
     job_not_found: 'JOB_NOT_FOUND',

spec/jobs/school_import_job_spec.rb

@@ -81,6 +81,27 @@
       end
     end
 
+    context 'when owner already has a role in another school' do
+      let(:existing_school) { create(:school, name: 'Existing School') }
+
+      before do
+        Role.owner.create!(school_id: existing_school.id, user_id: owner1_id)
+      end
+
+      it 'adds failed result for that school' do
+        results = described_class.new.perform(
+          schools_data: [schools_data.first],
+          user_id: user_id
+        )
+
+        expect(results[:successful].count).to eq(0)
+        expect(results[:failed].count).to eq(1)
+        expect(results[:failed].first[:error_code]).to eq('OWNER_HAS_EXISTING_ROLE')
+        expect(results[:failed].first[:error]).to include('already has a role in school')
+        expect(results[:failed].first[:existing_school_id]).to eq(existing_school.id)
+      end
+    end
+
     context 'when schools_data has string keys (simulating ActiveJob serialization)' do
       let(:schools_data_with_string_keys) do
         [