Added partial train and cluster commands #452
Open
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
sgalkina
reviewed
Jul 7, 2025
…ity to use different options. Work in progress.
sgalkina
reviewed
Jul 28, 2025
sgalkina
reviewed
Jul 28, 2025
sgalkina
reviewed
Jul 28, 2025
sgalkina
reviewed
Jul 28, 2025
…onality so it makes more sense
sgalkina
reviewed
Jul 31, 2025
sgalkina
reviewed
Jul 31, 2025
jakobnissen
requested changes
Jul 31, 2025
Member
jakobnissen
left a comment
jakobnissen
left a comment
There was a problem hiding this comment.
Good progress - let's have a meeting about this.
ElekLamoureux
changed the title
sgalkina
reviewed
Aug 14, 2025
added 2 commits
August 14, 2025 11:12
…ses instead of strings for mode checking.
jakobnissen
requested changes
Aug 14, 2025
Member
jakobnissen
left a comment
jakobnissen
left a comment
There was a problem hiding this comment.
Thanks! A few changes but overall it looks good
Comment on lines
+1452
to
+1462
| class RunDefault: | ||
| pass | ||
|
|
||
|
|
||
| class RunTrain: | ||
| pass | ||
|
|
||
|
|
||
| class RunCluster: | ||
| def __init__(self, latent: Path): | ||
| self.latent = latent |
Member
There was a problem hiding this comment.
@sgalkina I suggested this pattern, to mimick an ADT (or enum, in Rust parlance). My idea is to 1) statically check that the argument is the correct type, and 2) make it easier to catch errors if a new partial mode is added. Is there a better way in Python to make ADTs that can be caught by the type checker?
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
3 participants
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Added a command that trains and returns latent.npz. Still in testing …