Include E_NOTICE and E_WARNING in default report-only error levels#65
Merged
tommitchelmore merged 1 commit intomasterfrom Mar 24, 2026
Merged
Include E_NOTICE and E_WARNING in default report-only error levels#65tommitchelmore merged 1 commit intomasterfrom
tommitchelmore merged 1 commit intomasterfrom
Conversation
tommitchelmore
force-pushed
the
fix/error-reporting-levels
branch
from
921220e to
d618180
Compare
richstandbrook
approved these changes
Mar 24, 2026
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
The default error handler policy converts E_NOTICE and E_WARNING into ErrorException instances. This "fatalises" non-blocking PHP issues, causing script termination for recoverable events (e.g., undefined array keys). In a WordPress environment, this strictness leads to unnecessary crashes for minor issues that do not inherently prevent a successful response.
Solution: added E_NOTICE and E_WARNING to the default $errorsToReportOnly array in RegisterExceptionHandler::handleError. These levels will now be reported to the configured logger but will no longer throw an exception that halts execution.