Skip to content

Conversation

@attil1o
Copy link
Contributor

@attil1o attil1o commented Dec 6, 2025

2

Copilot AI review requested due to automatic review settings December 6, 2025 17:57
@loathingKernel
Copy link
Contributor

loathingKernel commented Dec 6, 2025

Please make it into an alternative standalone style, and handle all themed components to look uniform.

Copy link

Copilot AI left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Pull request overview

This pull request updates the theme's accent color from dark purple/slate blue (rgb(72, 61, 139)) to cyan (rgb(93, 187, 204)), which matches the application's logo. The update also modernizes the design by removing gradient backgrounds in favor of a flat design aesthetic. The changes span the QSS stylesheet template, the generated stylesheet, and the compiled binary resources.

Key changes:

  • Replaced primary border color from #483d8b (dark purple) to #5dbbcc (cyan)
  • Replaced highlight border color from #5246a0 to #7fd4e0 (lighter cyan)
  • Removed all qlineargradient declarations, replacing them with solid colors
  • Updated comments to reflect "flat backgrounds" instead of "gradient backgrounds"

Reviewed changes

Copilot reviewed 3 out of 3 changed files in this pull request and generated 4 comments.

File Description
rare/resources/stylesheets/RareStyle/template.qss Updated color definitions, replaced purple theme with cyan, removed gradient backgrounds, updated alpha blend calculations
rare/resources/stylesheets/RareStyle/stylesheet.qss Applied color changes from template to generated stylesheet, removed all gradient declarations
rare/resources/stylesheets/RareStyle/__init__.py Regenerated binary Qt resource file to reflect the stylesheet changes

💡 Add Copilot custom instructions for smarter, more guided reviews. Learn how to get started.

border-color: rgb( 93, 187, 204);
padding: 1px;
background-color: rgb( 42, 40, 63);
background-color: rgb( 55, 81, 88);
Copy link

Copilot AI Dec 6, 2025

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

This background color should be rgb( 47, 72, 79) instead of rgb( 55, 81, 88) to correctly represent rgba(93, 187, 204, 25%) blended over the background rgb(32, 34, 37).

Copilot uses AI. Check for mistakes.
border-color: rgb( 93, 187, 204);
padding: 1px;
background-color: rgb( 42, 40, 63);
background-color: rgb( 55, 81, 88);
Copy link

Copilot AI Dec 6, 2025

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

This background color should be rgb( 47, 72, 79) instead of rgb( 55, 81, 88) to correctly represent rgba(93, 187, 204, 25%) blended over the background rgb(32, 34, 37).

Suggested change
background-color: rgb( 55, 81, 88);
background-color: rgb( 47, 72, 79);

Copilot uses AI. Check for mistakes.
normal: #483d8b rgb( 72, 61, 139) -- border color for most widgets
rgba( 72, 61, 139, 25%) == rgb( 42, 40, 63)
normal: #5dbbcc rgb( 93, 187, 204) -- border color for most widgets (cyan from logo)
rgba( 93, 187, 204, 25%) == rgb( 55, 81, 88)
Copy link

Copilot AI Dec 6, 2025

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

The calculated RGB value for rgba(93, 187, 204, 25%) blended over the background rgb(32, 34, 37) is incorrect.

Correct calculation:

  • Red: 93 × 0.25 + 32 × 0.75 = 23.25 + 24 = 47.25 ≈ 47
  • Green: 187 × 0.25 + 34 × 0.75 = 46.75 + 25.5 = 72.25 ≈ 72
  • Blue: 204 × 0.25 + 37 × 0.75 = 51 + 27.75 = 78.75 ≈ 79

The value should be rgb( 47, 72, 79) instead of rgb( 55, 81, 88).

This also affects line 410 where this calculated color is used as a background-color.

Copilot uses AI. Check for mistakes.
stop: 1 rgb( 32, 34, 37));
*/
background-color: rgb( 42, 40, 63);
background-color: rgb( 55, 81, 88);
Copy link

Copilot AI Dec 6, 2025

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

This background color should be rgb( 47, 72, 79) instead of rgb( 55, 81, 88) to correctly represent rgba(93, 187, 204, 25%) blended over the background rgb(32, 34, 37). See the comment on line 16 for the calculation details.

Suggested change
background-color: rgb( 55, 81, 88);
background-color: rgb( 47, 72, 79);

Copilot uses AI. Check for mistakes.
@loathingKernel
Copy link
Contributor

The layout changes are irrelevant this this PR, I do not want this PR to touch RareStyle. If you want an alternative stylesheet, then create a new one. I don't mind basing it on RareStyle, but I do not want the default style to change at this point.

@attil1o attil1o marked this pull request as draft January 5, 2026 21:32
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

2 participants