Delay equipment loading by 2 ticks and add protection against quick GUI closure#26
Open
WMGameLive wants to merge 1 commit intoRapha149:mainfrom
Open
Delay equipment loading by 2 ticks and add protection against quick GUI closure#26WMGameLive wants to merge 1 commit intoRapha149:mainfrom
WMGameLive wants to merge 1 commit intoRapha149:mainfrom
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
1 participant
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
There's a bug where sometimes equipment gets placed into the GUI before the GUI finishes initializing, which means the equipment doesn't load properly and gets permanently lost. I've added a 2-tick delay to make sure the GUI is ready before placing the equipment.
I tested this 200 times with no delay or just 1 tick, the bug still happened occasionally, but with 2 ticks it never occurred again.
I've also added a safety check to prevent equipment loss when players close the GUI too quickly before the equipment finishes loading.
It might solve #24 .