Preserve life support suit levels when exiting various entities#121
Open
PhaserArray wants to merge 8 commits intoRafaelDeJongh:masterfrom
Open
Preserve life support suit levels when exiting various entities#121PhaserArray wants to merge 8 commits intoRafaelDeJongh:masterfrom
PhaserArray wants to merge 8 commits intoRafaelDeJongh:masterfrom
Conversation
Fix ExitKino using ply instead of self.ply fix kino exit suit persist
fix shuttle suit persist
Collaborator
|
Oh needed review this before made update for cap today, ok will try to look into this next time |
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
When exiting ships and some other entities, CAP essentially respawns the player at the exit position. That makes Spacebuild think the player died, which causes the player's life support suit to reset. This pull request makes affected entities store the life support suit levels prior to respawning the pilot and sets them back to the stored levels afterwards.
Additionally, commit 4912654 makes the Teltak's LSSupport function only set suit values when they're less than what they would be set to. This was already the case with the Puddle Jumper's LSSupport function, but not the Teltak's.