Fix/stow response fix #111
Open
+2,467
−12,744
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
…rect-pixel-representation
rleisti
reviewed
Jan 28, 2026
rleisti
requested changes
Jan 28, 2026
| streamInfo.failed = true; | ||
|
|
||
| // Terminate the stream by destroying it | ||
| try { |
Collaborator
There was a problem hiding this comment.
Closing all internal stream should be a responsibility of the StreamInfo class
| import { StreamInfo } from '../lib/instance/StreamInfo.mjs'; | ||
|
|
||
| describe('StreamInfo write and end', () => { | ||
| test('writes Buffer, array of Buffer and TypedArray via write(); returns backpressure; queues when busy', async () => { |
Collaborator
There was a problem hiding this comment.
This test only validates negative backpressure (returning true): there isn't a case to validate when write returns false
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Fixes a number of crash issues caused by not handling promise rejections correclty and various other issues.