Feat/teammate card#80
Open
den987655 wants to merge 5 commits into
Open
Conversation
elrouss
requested changes
May 30, 2026
Member
elrouss
left a comment
elrouss
left a comment
There was a problem hiding this comment.
Overall, the PR looks solid!
I've left a few minor comments to fix. As a general piece of feedback, it looks like the default test file teamate-card.component.spec.ts is missing. Please make sure to include it
| @@ -0,0 +1,26 @@ | |||
| <article class="card"> | |||
Member
There was a problem hiding this comment.
praise: Great choice of a semantic tag!
den987655
force-pushed
the
feat/teammate-card
branch
from
a366531 to
d58ed91
Compare
elrouss
approved these changes
Jun 1, 2026
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
📝 Summary of Changes
Added reusable TeammateCard component for the About page.
Implemented flip-card interaction with front/back sides on hover.
Added configurable inputs for teammate information:
Implemented card layout and styling using BEM structure.
Added support for external profile links.
🖼️ UI Changes (Mandatory for frontend/UI tasks)
🛠️ Pre-Review Checklist
mainnpm run tsc,npm run lint, etc.)👥 Reviewer Checklist
[praise],[nit],[question](unprefixed comments = hard blockers)