Enable regions with the same name to be repeated multiple times on a page#27
Enable regions with the same name to be repeated multiple times on a page#27willprice76 wants to merge 9 commits intoRWS:developfrom
Conversation
|
Can you please do a separate Pull Request for the separate issue (region route values)? |
|
Sorry Rick - I got confused between my various branches and pull requests. I think everything is as it should be now... |
…now duplicate regions are possible, this enables us to have, for example two consecutive 3-Column regions with different parameters (so separate view configuration)
| } | ||
| else | ||
| { | ||
| Log.Debug("Region '{0}' is defined with different MVC data: [{1}] and [{2}]. Starting a new region.", regionName, currentRegion.MvcData, cpRegionMvcData); |
There was a problem hiding this comment.
Note that now we can have duplicate regions, a change in MVC data can simply trigger a new region of the same name. This ties in nicely with PR #29 which allows regions to be configurable via CT metadata. In this case we would want to start a new region if the region route values were different
|
How likely is it that this will be merged and is it imminent? |
|
we are considering this for the DXA 1.6 release, but we have to check it against the plans for region support in SDL Web, since it does not make sense to include it now, with the possibility to remove it later if there will be different region support in the CME. |
|
TSI-1945 (internal issue ID for tracking purposes) |
4 participants
This fixes issue #26