Added rvc/lib/uvr5_pack/ffio.py with audio-loading functions based on ffmpeg and librosa.resample as an option for UVR5
#63
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
This function reads audio files using ffmpeg, allowing for asynchronous reading and various output configurations.
…mpling Updated `wavread` function to include resampling using `librosa`, & added `wavread_rosa` for `librosa`-like params. Due to that the param `res_type` is defined in `librosa`, resampling is performed using `librosa.resample` as well.
Added option to load audio using ffmpeg in process method.
The function is implemented in new file `.../uvr5_pack/ffio.py`. However, it hasn't been performed serious unit tests yet due to that I'm not sure what kind of unit tests are required.
Author
|
新增函数 由于参数 但由于不确定需要何种单元测试，目前尚未进行/通过单元测试。 我是在读 UVR5 实现时发现的或许可以改动的此处，但还没做单元测试，其实不仅是因为不知道应该做哪些单元测试，同时也是因为以前没做过 😂 |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
1 participant
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Functions
wavread&wavread_rosaare added, where the latter is called asffread_rosain the filervc/modules/uvr5/vr.pyas an alternative, in order to avoid bugs thatlibrosa(.core).loadmay cause.Due to that the param
res_typeis defined inlibrosa, the resampling is also performed bylibrosa.resamplein the function(s).However, due to that I'm not sure what kind of unit tests are required, it hasn't been performed / passed unit tests.