Skip to content

Conversation

@bonedaddy
Copy link
Contributor

@bonedaddy bonedaddy commented Apr 28, 2020

  • No real changes in this repo, instead the majority of the changes are within testenv and enable spinning up a single node cockroachdb cluster, instead of a postgresql node
  • Enable a more secure db connection via client certificate auth

TODOs

  • Add testing for secure db connection via certificates
    • This needs us to update the config package

@codecov
Copy link

codecov bot commented Apr 28, 2020

Codecov Report

Merging #58 into master will decrease coverage by 0.82%.
The diff coverage is 8.33%.

Impacted file tree graph

@@            Coverage Diff             @@
##           master      #58      +/-   ##
==========================================
- Coverage   70.02%   69.19%   -0.83%     
==========================================
  Files          15       15              
  Lines        1121     1133      +12     
==========================================
- Hits          785      784       -1     
- Misses        223      235      +12     
- Partials      113      114       +1     
Impacted Files Coverage Δ
database.go 67.24% <8.33%> (-19.72%) ⬇️

Continue to review full report at Codecov.

Legend - Click here to learn more
Δ = absolute <relative> (impact), ø = not affected, ? = missing data
Powered by Codecov. Last update 220621d...f7631ae. Read the comment docs.

@gerardwebb
Copy link

Is this not longer a priority ?

Just asking because HA was the obvious thing i was looking for.

@bonedaddy
Copy link
Contributor Author

bonedaddy commented Jun 17, 2020

@gerardwebb This PR is technically tabled for now, however you can already use the database package in this repo with CockroachDB as it is wire compatible with postgres. The only difference however which this PR fixes, is that you can't do client-certificate authentication with any of the code in master or any releases.

Also you can technically implement HA out of this library, via logical replication and other stuff, but its annoying as fuck tosetup

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

3 participants