Skip to content

Comments

V5.2.2 beta#11204

Open
ShiHongChao wants to merge 5 commits intoRT-Thread:v5.2.2-betafrom
ShiHongChao:v5.2.2-beta
Open

V5.2.2 beta#11204
ShiHongChao wants to merge 5 commits intoRT-Thread:v5.2.2-betafrom
ShiHongChao:v5.2.2-beta

Conversation

@ShiHongChao
Copy link

@ShiHongChao ShiHongChao commented Feb 18, 2026 •
edited
Loading

拉取/合并请求描述：(PR description)

[

为什么提交这份PR (why to submit this PR)

  • gd32硬件i2c驱动时序有问题，导致IIC读一直等待
  • 添加PWM和更多硬件定时器支持
  • 增加GDF405RG芯片BSP

你的解决方案是什么 (what is your solution)

  • 原来的驱动采用方案A，并且时序有问题，严格参照GD32官方手册提供的时序进行修复，并且添加对方案B的支持

请提供验证的bsp和config (provide the config and bsp)

  • BSP: bsp/gd32/arm/gd32405rg
  • .config:
  • action:

]

当前拉取/合并请求的状态 Intent for your PR

必须选择一项 Choose one (Mandatory):

  • 本拉取/合并请求是一个草稿版本 This PR is for a code-review and is intended to get feedback
  • 本拉取/合并请求是一个成熟版本 This PR is mature, and ready to be integrated into the repo

代码质量 Code Quality：

我在这个拉取/合并请求中已经考虑了 As part of this pull request, I've considered the following:

  • 已经仔细查看过代码改动的对比 Already check the difference between PR and old code
  • 代码风格正确，包括缩进空格，命名及其他风格 Style guide is adhered to, including spacing, naming and other styles
  • 没有垃圾代码，代码尽量精简，不包含#if 0代码，不包含已经被注释了的代码 All redundant code is removed and cleaned up
  • 所有变更均有原因及合理的，并且不会影响到其他软件组件代码或BSP All modifications are justified and not affect other components or BSP
  • 对难懂代码均提供对应的注释 I've commented appropriately where code is tricky
  • 代码是高质量的 Code in this PR is of high quality
  • 已经使用formatting 等源码格式化工具确保格式符合RT-Thread代码规范 This PR complies with RT-Thread code specification
  • 如果是新增bsp, 已经添加ci检查到.github/ALL_BSP_COMPILE.json 详细请参考链接BSP自查

@ShiHongChao
feat(bsp/gd32): 增加GDF0RG芯片BSP
9310458
@ShiHongChao
feat(bsp/gd32): 添加PWM和更多硬件定时器支持
eb7576d 
- 在Kconfig中添加BSP_USING_PWM和BSP_USING_HWTIMER配置项
- 修正PWM时钟获取逻辑，使其能正确得到APB1/APB2上的定时器时钟源频率，添加在pwm结构体通道引脚资源配置项
- 修改硬件定时器初始化逻辑，修正定时器中断处理函数，适配GD32F4xx系列
- 在main.c中添加hwtimer_test和pwm_test测试函数
- 修复PWM和硬件定时器的依赖关系配置
@ShiHongChao
fix(bsp/gd32/arm): 修复gd32硬件i2c驱动
f3a45ba 
- 硬件i2c主机接收驱动采用方案B，但不支持接收小于3字节，现修复该问题
- 增加方案A。
@ShiHongChao
chore(.github): 添加GD32405RG开发板支持
6171745 
- 在ALL_BSP_COMPILE.json配置文件中新增gd32405rg开发板
@github-actions
Copy link

github-actions bot commented Feb 18, 2026

👋 感谢您对 RT-Thread 的贡献！Thank you for your contribution to RT-Thread!

为确保代码符合 RT-Thread 的编码规范，请在你的仓库中执行以下步骤运行代码格式化工作流（如果格式化CI运行失败）。
To ensure your code complies with RT-Thread's coding style, please run the code formatting workflow by following the steps below (If the formatting of CI fails to run).

🛠 操作步骤 | Steps

  1. 前往 Actions 页面 | Go to the Actions page
    点击进入工作流 → | Click to open workflow →

  2. 点击 Run workflow | Click Run workflow

  • 设置需排除的文件/目录（目录请以"/"结尾）
    Set files/directories to exclude (directories should end with "/")
  • 将目标分支设置为 \ Set the target branch to：v5.2.2-beta
  • 设置PR number为 \ Set the PR number to：11204
  1. 等待工作流完成 | Wait for the workflow to complete
    格式化后的代码将自动推送至你的分支。
    The formatted code will be automatically pushed to your branch.

完成后，提交将自动更新至 v5.2.2-beta 分支，关联的 Pull Request 也会同步更新。
Once completed, commits will be pushed to the v5.2.2-beta branch automatically, and the related Pull Request will be updated.

如有问题欢迎联系我们，再次感谢您的贡献！💐
If you have any questions, feel free to reach out. Thanks again for your contribution!

@github-actions github-actions bot added BSP action github action yml imporve BSP: GD32 BSP related with GD32 labels Feb 18, 2026
@BernardXiong BernardXiong requested a review from Copilot February 20, 2026 09:24
Copilot AI reviewed Feb 20, 2026
View reviewed changes
Copy link
Contributor

Copilot AI left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Pull request overview

This pull request adds support for the GD32F405RG chip BSP and includes important driver fixes for GD32 hardware I2C, PWM, and hardware timer peripherals.

Changes:

  • Adds new BSP for GD32405RG chip with complete board support files, linker scripts, and configuration
  • Fixes GD32 hardware I2C driver timing issues that caused IIC read operations to hang, and adds support for both Mode A and Mode B reception schemes
  • Refactors and optimizes PWM driver with improved timer clock frequency calculation, better structure design, and support for more hardware timers (TIMER0-13)
  • Enhances hardware timer driver with proper GD32F4xx interrupt handler configuration, relocated initialization, and deinit functionality

Reviewed changes

Copilot reviewed 31 out of 36 changed files in this pull request and generated 3 comments.

Show a summary per file
File Description
drv_pwm.c Complete refactoring of PWM driver with optimized structure, improved clock calculation, and support for 14 timers
drv_hard_i2c.c Fixed I2C master receive timing issues and added Mode A/B support with proper ACK/NACK handling
drv_hwtimer.c Added GD32F4xx interrupt handlers, relocated clock/interrupt initialization to init function, implemented deinit
gd32405rg/* New BSP with board files, linker scripts, Kconfig, applications, and build scripts
ALL_BSP_COMPILE.json Added gd32405rg to CI compilation list

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Reviewers

Copilot code review Copilot Copilot left review comments

@kurisaW kurisaW Awaiting requested review from kurisaW kurisaW is a code owner

@supperthomas supperthomas Awaiting requested review from supperthomas supperthomas is a code owner

Assignees

No one assigned

Labels

action github action yml imporve BSP: GD32 BSP related with GD32 BSP

Projects

None yet

Milestone

No milestone

Development

Successfully merging this pull request may close these issues.

1 participant

@ShiHongChao