Conversation
|
|
…ition error Co-authored-by: BernardXiong <1241087+BernardXiong@users.noreply.github.com>
Copilot
AI
changed the title
[WIP] Fix multiple definition of rt_hw_cpu_shutdown with RT_USING_DM
[risc-v][common64] Make rt_hw_cpu_shutdown weak to resolve multiple definition with RT_USING_DM
Dec 28, 2025
📌 Code Review Assignment🏷️ Tag: libcpu_riscvReviewers: @Yaochenger Changed Files (Click to expand)
📊 Current Review Status (Last Updated: 2025-12-29 07:37 CST)
📝 Review Instructions
|
BernardXiong
approved these changes
Dec 28, 2025
Rbb666
approved these changes
Jan 12, 2026
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
When
RT_USING_DMis enabled, bothlibcpu/risc-v/common64/cpuport.candcomponents/drivers/core/power.cdefinert_hw_cpu_shutdown, causing linker failure.Changes
rt_hw_cpu_shutdowninlibcpu/risc-v/common64/cpuport.casrt_weakThis allows the power management implementation to override the default cpuport version when device manager is enabled, while maintaining the fallback for configurations without DM.
Affects RISC-V 64-bit architectures: virt64, c906, c908, ur-cp100.
Original prompt
💬 We'd love your input! Share your thoughts on Copilot coding agent in our 2 minute survey.