[docs][libcpu][arm][cortex-a] update comment for start_gcc.S#11089
Merged
Rbb666 merged 2 commits intoRT-Thread:masterfrom Dec 26, 2025
Merged
[docs][libcpu][arm][cortex-a] update comment for start_gcc.S#11089Rbb666 merged 2 commits intoRT-Thread:masterfrom
Rbb666 merged 2 commits intoRT-Thread:masterfrom
Conversation
|
👋 感谢您对 RT-Thread 的贡献!Thank you for your contribution to RT-Thread! 为确保代码符合 RT-Thread 的编码规范,请在你的仓库中执行以下步骤运行代码格式化工作流(如果格式化CI运行失败)。 🛠 操作步骤 | Steps
完成后,提交将自动更新至 如有问题欢迎联系我们,再次感谢您的贡献!💐 |
Rbb666
approved these changes
Dec 26, 2025
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
拉取/合并请求描述:(PR description)
[
为什么提交这份PR (why to submit this PR)
我认为注释不够准确,所以修改部分注释。
你的解决方案是什么 (what is your solution)
1 删除不必要的注释。
2 优化我认为可以详细的注释。
3 添加部分注释。
请提供验证的bsp和config (provide the config and bsp)
]
当前拉取/合并请求的状态 Intent for your PR
必须选择一项 Choose one (Mandatory):
代码质量 Code Quality:
我在这个拉取/合并请求中已经考虑了 As part of this pull request, I've considered the following:
#if 0代码,不包含已经被注释了的代码 All redundant code is removed and cleaned up改动声明
1 删除不必要的注释
我认为这些注释是不必要的,因为只是对语法的解释。所以删除掉了。
2 优化我认为可以详细的注释
我觉得宏定义的注释可以更详细,所以修改如下
还有我认为不准确的注释。
这部分的作用是先禁用MMU,然后再失效TLB I-cache和分支预测。
但是原注释的内容是 /* invalid tlb before enable mmu */ 在使能MMU前失效TLB。
我认为不准确。
3 添加部分注释
在CP15寄存器组的旁边加上操作的寄存器名称。
对于CPACR和MPIDR这种有多种实现的寄存器,读写值不添加注释。
对于SCTLR这种通用的寄存器,写入值时添加写入了具体字段。
测试
纯注释修改
