bsp: stm32f407-micu: add onboard spi flash support by Dailingxiang1 · Pull Request #11065 · RT-Thread/rt-thread

Dailingxiang1 · 2025-12-15T12:23:26Z

拉取/合并请求描述：(PR description)

[

为什么提交这份PR (why to submit this PR)

This PR adds onboard SPI flash support for stm32f407-micu BSP.

你的解决方案是什么 (what is your solution)

Add menuconfig option to enable onboard SPI flash
Initialize SPI flash device via SFUD
Enable SPI peripheral through CubeMX configuration

请提供验证的bsp和config (provide the config and bsp)

Board: stm32f407-micu
SPI flash: W25Qxx
Verified SFUD probe and basic read/write

BSP: bsp/stm32/stm32f407-micu

.config: CONFIG_BSP_USING_ON_BOARD_FLASH=y

]

当前拉取/合并请求的状态 Intent for your PR

必须选择一项 Choose one (Mandatory):

本拉取/合并请求是一个草稿版本 This PR is for a code-review and is intended to get feedback
本拉取/合并请求是一个成熟版本 This PR is mature, and ready to be integrated into the repo

代码质量 Code Quality：

我在这个拉取/合并请求中已经考虑了 As part of this pull request, I've considered the following:

已经仔细查看过代码改动的对比 Already check the difference between PR and old code
代码风格正确，包括缩进空格，命名及其他风格 Style guide is adhered to, including spacing, naming and other styles
没有垃圾代码，代码尽量精简，不包含#if 0代码，不包含已经被注释了的代码 All redundant code is removed and cleaned up
所有变更均有原因及合理的，并且不会影响到其他软件组件代码或BSP All modifications are justified and not affect other components or BSP
对难懂代码均提供对应的注释 I've commented appropriately where code is tricky
代码是高质量的 Code in this PR is of high quality
已经使用formatting 等源码格式化工具确保格式符合RT-Thread代码规范 This PR complies with RT-Thread code specification
如果是新增bsp, 已经添加ci检查到.github/ALL_BSP_COMPILE.json 详细请参考链接BSP自查

github-actions · 2025-12-15T12:23:33Z

👋 感谢您对 RT-Thread 的贡献！Thank you for your contribution to RT-Thread!

为确保代码符合 RT-Thread 的编码规范，请在你的仓库中执行以下步骤运行代码格式化工作流（如果格式化CI运行失败）。
To ensure your code complies with RT-Thread's coding style, please run the code formatting workflow by following the steps below (If the formatting of CI fails to run).

🛠 操作步骤 | Steps

前往 Actions 页面 | Go to the Actions page
点击进入工作流 → | Click to open workflow →
点击 Run workflow | Click Run workflow

设置需排除的文件/目录（目录请以"/"结尾）
Set files/directories to exclude (directories should end with "/")
将目标分支设置为 \ Set the target branch to：feat/stm32f407-micu-onboard-spiflash
设置PR number为 \ Set the PR number to：11065

等待工作流完成 | Wait for the workflow to complete
格式化后的代码将自动推送至你的分支。
The formatted code will be automatically pushed to your branch.

完成后，提交将自动更新至 feat/stm32f407-micu-onboard-spiflash 分支，关联的 Pull Request 也会同步更新。
Once completed, commits will be pushed to the feat/stm32f407-micu-onboard-spiflash branch automatically, and the related Pull Request will be updated.

如有问题欢迎联系我们，再次感谢您的贡献！💐
If you have any questions, feel free to reach out. Thanks again for your contribution!

github-actions · 2025-12-15T12:23:38Z

📌 Code Review Assignment

🏷️ Tag: bsp_stm32

Reviewers: Liang1795 hamburger-os wdfk-prog

Changed Files (Click to expand)

bsp/stm32/stm32f407-micu/board/CubeMX_Config/.mxproject
bsp/stm32/stm32f407-micu/board/CubeMX_Config/CubeMX_Config.ioc
bsp/stm32/stm32f407-micu/board/CubeMX_Config/Inc/main.h
bsp/stm32/stm32f407-micu/board/CubeMX_Config/Inc/stm32f4xx_hal_conf.h
bsp/stm32/stm32f407-micu/board/CubeMX_Config/Src/main.c
bsp/stm32/stm32f407-micu/board/CubeMX_Config/Src/stm32f4xx_hal_msp.c
bsp/stm32/stm32f407-micu/board/CubeMX_Config/Src/stm32f4xx_it.c
bsp/stm32/stm32f407-micu/board/CubeMX_Config/Src/system_stm32f4xx.c
bsp/stm32/stm32f407-micu/board/Kconfig
bsp/stm32/stm32f407-micu/board/ports/SConscript
bsp/stm32/stm32f407-micu/board/ports/spi_flash_init.c

🏷️ Tag: bsp_stm32f407-micu

Reviewers: Dailingxiang1

Changed Files (Click to expand)

bsp/stm32/stm32f407-micu/board/CubeMX_Config/.mxproject
bsp/stm32/stm32f407-micu/board/CubeMX_Config/CubeMX_Config.ioc
bsp/stm32/stm32f407-micu/board/CubeMX_Config/Inc/main.h
bsp/stm32/stm32f407-micu/board/CubeMX_Config/Inc/stm32f4xx_hal_conf.h
bsp/stm32/stm32f407-micu/board/CubeMX_Config/Src/main.c
bsp/stm32/stm32f407-micu/board/CubeMX_Config/Src/stm32f4xx_hal_msp.c
bsp/stm32/stm32f407-micu/board/CubeMX_Config/Src/stm32f4xx_it.c
bsp/stm32/stm32f407-micu/board/CubeMX_Config/Src/system_stm32f4xx.c
bsp/stm32/stm32f407-micu/board/Kconfig
bsp/stm32/stm32f407-micu/board/ports/SConscript
bsp/stm32/stm32f407-micu/board/ports/spi_flash_init.c

📊 Current Review Status (Last Updated: 2025-12-18 14:26 CST)

⌛ Dailingxiang1 Pending Review
⌛ Liang1795 Pending Review
⌛ hamburger-os Pending Review
⌛ wdfk-prog Pending Review

📝 Review Instructions

维护者可以通过单击此处来刷新审查状态: 🔄 刷新状态
Maintainers can refresh the review status by clicking here: 🔄 Refresh Status
确认审核通过后评论 LGTM/lgtm
Comment LGTM/lgtm after confirming approval
PR合并前需至少一位维护者确认
PR must be confirmed by at least one maintainer before merging

ℹ️ 刷新CI状态操作需要具备仓库写入权限。
ℹ️ Refresh CI status operation requires repository Write permission.

Rbb666 · 2025-12-18T03:38:47Z

bsp/stm32/stm32f407-micu/board/CubeMX_Config/Inc/stm32f4xx_hal_conf.h

 /* #define HAL_SAI_MODULE_ENABLED */
 /* #define HAL_SD_MODULE_ENABLED */
 /* #define HAL_MMC_MODULE_ENABLED */
-/* #define HAL_SPI_MODULE_ENABLED */


这块是不是只提交这块的修改即可，其他的感觉是格式问题

勾选SPI引脚后，用CubeMX重新生成了一遍，所以整个CubeMX_Config文件夹都发生了变化

Rbb666 · 2025-12-18T03:40:30Z

bsp/stm32/stm32f407-micu/board/ports/SConscript

+CPPDEFINES = ['STM32F407xx']
+group = DefineGroup('Drivers', src, depend = [''], CPPPATH = path, CPPDEFINES = CPPDEFINES)
+
+list = os.listdir(cwd)


这段代码应该是没有作用的

Rbb666 · 2025-12-18T03:40:40Z

bsp/stm32/stm32f407-micu/board/ports/SConscript

+src = []
+path =  [cwd]
+
+


删除多余的换行

Rbb666 · 2025-12-18T03:41:36Z

bsp/stm32/stm32f407-micu/board/ports/spi_flash_init.c

+#include <drv_spi.h>
+#include <drv_gpio.h>
+
+#if defined(BSP_USING_ON_BOARD_FLASH)


Scons脚本中已经进行了筛选，这块可以不加

Rbb666 · 2025-12-18T03:41:59Z

bsp/stm32/stm32f407-micu/board/Kconfig

+        select BSP_USING_UART
+        select BSP_USING_UART1
+        default y
+    config BSP_USING_ON_BOARD_FLASH


加个换行

Rbb666 · 2025-12-18T03:42:26Z

请给出测试截图

Dailingxiang1 · 2025-12-18T06:28:22Z

测试截图

Dailingxiang1 · 2025-12-19T01:58:19Z

请给出测试截图

已给出

github-actions bot added BSP: STM32 BSP related with ST/STM32 BSP labels Dec 15, 2025

bsp: stm32f407-micu: add onboard spi flash support

4cd76ab

Dailingxiang1 force-pushed the feat/stm32f407-micu-onboard-spiflash branch from 1dfec8e to 4cd76ab Compare December 15, 2025 12:38

Rbb666 reviewed Dec 18, 2025

View reviewed changes

bsp(stm32f407-micu): cleanup SConscript formatting and dead code

663e853

Rbb666 approved these changes Dec 22, 2025

View reviewed changes

Rbb666 merged commit dd3cee9 into RT-Thread:master Dec 22, 2025
32 checks passed

		src = []
		path = [cwd]

Conversation

Dailingxiang1 commented Dec 15, 2025 • edited Loading Uh oh! There was an error while loading. Please reload this page.

Uh oh!

拉取/合并请求描述：(PR description)

为什么提交这份PR (why to submit this PR)

你的解决方案是什么 (what is your solution)

请提供验证的bsp和config (provide the config and bsp)

当前拉取/合并请求的状态 Intent for your PR

代码质量 Code Quality：

Uh oh!

github-actions bot commented Dec 15, 2025

🛠 操作步骤 | Steps

Uh oh!

github-actions bot commented Dec 15, 2025 • edited Loading Uh oh! There was an error while loading. Please reload this page.

Uh oh!

📌 Code Review Assignment

🏷️ Tag: bsp_stm32

🏷️ Tag: bsp_stm32f407-micu

📊 Current Review Status (Last Updated: 2025-12-18 14:26 CST)

📝 Review Instructions

Uh oh!

Choose a reason for hiding this comment

Uh oh!

Choose a reason for hiding this comment

Uh oh!

Choose a reason for hiding this comment

Uh oh!

Choose a reason for hiding this comment

Uh oh!

Choose a reason for hiding this comment

Uh oh!

Choose a reason for hiding this comment

Uh oh!

Choose a reason for hiding this comment

Uh oh!

Choose a reason for hiding this comment

Uh oh!

Choose a reason for hiding this comment

Uh oh!

Choose a reason for hiding this comment

Uh oh!

Rbb666 commented Dec 18, 2025

Uh oh!

Dailingxiang1 commented Dec 18, 2025

Uh oh!

Dailingxiang1 commented Dec 19, 2025

Uh oh!

Uh oh!

Reviewers

Assignees

Labels

Projects

Milestone

Development

Uh oh!

2 participants

Comments

Dailingxiang1 commented Dec 15, 2025 •

edited

Loading

github-actions bot commented Dec 15, 2025 •

edited

Loading