format/rsoc:clang format ignore migration#10829
Conversation
|
ache seems not to be a GitHub user. You need a GitHub account to be able to sign the CLA. If you have already a GitHub account, please add the email address used for this commit to your account. You have signed the CLA already but the status is still pending? Let us recheck it. |
📌 Code Review Assignment🏷️ Tag: bsp_cvitekReviewers: unicornx Changed Files (Click to expand)
🏷️ Tag: bsp_hc32Reviewers: levizh Changed Files (Click to expand)
📊 Current Review Status (Last Updated: 2025-10-24 22:26 CST)
📝 Review Instructions
|
|
👋 感谢您对 RT-Thread 的贡献!Thank you for your contribution to RT-Thread! 为确保代码符合 RT-Thread 的编码规范,请在你的仓库中执行以下步骤运行代码格式化工作流(如果格式化CI运行失败)。 🛠 操作步骤 | Steps
完成后,提交将自动更新至 如有问题欢迎联系我们,再次感谢您的贡献!💐 |
|
这个 PR 是干啥的,能否给点说明,或者有文档解释一下? |
58b1f94 to
7eaebc4
Compare
DescriptionMigrate Changes
BSPs Completed:
Scripts Updated:
|
tools/ci/file_check.py.backup
Outdated
There was a problem hiding this comment.
为啥要保留这些 backup 文件?我们不是有 git 吗?
tools/ci/format_ignore.py.backup
Outdated
There was a problem hiding this comment.
为啥要保留这些 backup 文件?我们不是有 git 吗?
|
tools/ci/format_ignore.py、tools/ci/file_check.py这两个是否本地运行测试通过? |
|
有一个冲突需要解决下,然后PR的标题修改下吧,写清楚这个PR修改了哪几个BSP |
db29db5 to
0757944
Compare
bsp/gd32/.clang-format-ignore
Outdated
There was a problem hiding this comment.
/arm/libraries下的GD32F10x_Firmware_Library这几个库都迁到软件包里了,这里的忽略脚本不需要了,可以自己多检查几遍
0757944 to
8e3c9fb
Compare
拉取/合并请求描述:(PR description)
[
为什么提交这份PR (why to submit this PR)
你的解决方案是什么 (what is your solution)
请提供验证的bsp和config (provide the config and bsp)
]
当前拉取/合并请求的状态 Intent for your PR
必须选择一项 Choose one (Mandatory):
代码质量 Code Quality:
我在这个拉取/合并请求中已经考虑了 As part of this pull request, I've considered the following:
#if 0代码,不包含已经被注释了的代码 All redundant code is removed and cleaned up