utilize the clang-format-ignore mechanism in bsp/nxp (#10764) by thomax2 · Pull Request #10827 · RT-Thread/rt-thread

thomax2 · 2025-10-16T14:13:48Z

拉取/合并请求描述：(PR description)

[

为什么提交这份PR (why to submit this PR)

统一NXP BSP的代码格式化忽略规则，采用与Renesas BSP相同的.clang-format-ignore机制

你的解决方案是什么 (what is your solution)

在bsp/nxp/下存在.ignore_format.yml的目录.clang-format-ignore文件
包含原有NXP BSP需要忽略的目录规则
删除原有的.ignore_format.yml文件

请提供验证的bsp和config (provide the config and bsp)

BSP: bsp/nxp/imx/imxrt/imxrt1060-nxp-evk

.config: 默认配置

action: 待PR创建后更新GitHub Actions验证链接。已本地验证.clang-format-ignore文件语法正确，与Renesas BSP实现一致。

]

当前拉取/合并请求的状态 Intent for your PR

必须选择一项 Choose one (Mandatory):

本拉取/合并请求是一个草稿版本 This PR is for a code-review and is intended to get feedback
本拉取/合并请求是一个成熟版本 This PR is mature, and ready to be integrated into the repo

代码质量 Code Quality：

我在这个拉取/合并请求中已经考虑了 As part of this pull request, I've considered the following:

已经仔细查看过代码改动的对比 Already check the difference between PR and old code
代码风格正确，包括缩进空格，命名及其他风格 Style guide is adhered to, including spacing, naming and other styles
没有垃圾代码，代码尽量精简，不包含#if 0代码，不包含已经被注释了的代码 All redundant code is removed and cleaned up
所有变更均有原因及合理的，并且不会影响到其他软件组件代码或BSP All modifications are justified and not affect other components or BSP
对难懂代码均提供对应的注释 I've commented appropriately where code is tricky
代码是高质量的 Code in this PR is of high quality
已经使用formatting 等源码格式化工具确保格式符合RT-Thread代码规范 This PR complies with RT-Thread code specification
如果是新增bsp, 已经添加ci检查到.github/ALL_BSP_COMPILE.json 详细请参考链接BSP自查

CLAassistant · 2025-10-16T14:13:55Z

All committers have signed the CLA.

github-actions · 2025-10-16T14:13:56Z

👋 感谢您对 RT-Thread 的贡献！Thank you for your contribution to RT-Thread!

为确保代码符合 RT-Thread 的编码规范，请在你的仓库中执行以下步骤运行代码格式化工作流（如果格式化CI运行失败）。
To ensure your code complies with RT-Thread's coding style, please run the code formatting workflow by following the steps below (If the formatting of CI fails to run).

🛠 操作步骤 | Steps

前往 Actions 页面 | Go to the Actions page
点击进入工作流 → | Click to open workflow →
点击 Run workflow | Click Run workflow

设置需排除的文件/目录（目录请以"/"结尾）
Set files/directories to exclude (directories should end with "/")
将目标分支设置为 \ Set the target branch to：master
设置PR number为 \ Set the PR number to：10827

等待工作流完成 | Wait for the workflow to complete
格式化后的代码将自动推送至你的分支。
The formatted code will be automatically pushed to your branch.

完成后，提交将自动更新至 master 分支，关联的 Pull Request 也会同步更新。
Once completed, commits will be pushed to the master branch automatically, and the related Pull Request will be updated.

如有问题欢迎联系我们，再次感谢您的贡献！💐
If you have any questions, feel free to reach out. Thanks again for your contribution!

github-actions · 2025-10-16T14:14:00Z

📌 Code Review Assignment

🏷️ Tag: bsp_mcxa

Reviewers: hywing

Changed Files (Click to expand)

bsp/nxp/mcx/mcxa/Libraries/.clang-format-ignore
bsp/nxp/mcx/mcxa/Libraries/.ignore_format.yml

🏷️ Tag: bsp_mcxn

Reviewers: hywing

Changed Files (Click to expand)

bsp/nxp/mcx/mcxn/Libraries/.ignore_format.yml

📊 Current Review Status (Last Updated: 2025-10-22 10:24 CST)

⌛ hywing Pending Review

📝 Review Instructions

维护者可以通过单击此处来刷新审查状态: 🔄 刷新状态
Maintainers can refresh the review status by clicking here: 🔄 Refresh Status
确认审核通过后评论 LGTM/lgtm
Comment LGTM/lgtm after confirming approval
PR合并前需至少一位维护者确认
PR must be confirmed by at least one maintainer before merging

ℹ️ 刷新CI状态操作需要具备仓库写入权限。
ℹ️ Refresh CI status operation requires repository Write permission.

kurisaW · 2025-10-21T12:07:08Z

bsp/nxp/lpc/lpc55sxx/Libraries/.clang-format-ignore

@@ -0,0 +1,13 @@
+# .clang-format-ignore File Description:


这个文件不需要，可以删掉，驱动库已经做成软件包了

bsp/nxp/imx/imxrt/imxrt1060-nxp-evk/.clang-format-ignore

kurisaW · 2025-10-21T12:08:55Z

bsp/nxp/imx/imxrt/libraries/.clang-format-ignore

@@ -0,0 +1,9 @@
+# .clang-format-ignore File Description:


这个文件可以删掉

kurisaW · 2025-10-21T12:09:24Z

bsp/nxp/mcx/mcxc/Libraries/.clang-format-ignore

@@ -0,0 +1,9 @@
+# .clang-format-ignore File Description:


可以删掉

kurisaW · 2025-10-21T12:09:43Z

bsp/nxp/mcx/mcxn/Libraries/.clang-format-ignore

@@ -0,0 +1,9 @@
+# .clang-format-ignore File Description:


可以删掉

自动化流程有两个报错
1.
RT-Thread BSP Static Build Check / arm-none-bsp-smart (pull_request)Failing after 1m
[cpp_check.py 80 INFO]
[cpp_check.py 79 INFO] Checking components/drivers/ktime/src/hrtimer.c ...
Checking components/drivers/ktime/src/hrtimer.c: RT_ASSERT(x)=;RTM_EXPORT(x)=;rt_list_for_each_entry(a,b,c)=a=(void*)b;...
Checking components/drivers/ktime/src/hrtimer.c: RT_ASSERT(x)=;RTM_EXPORT(x)=;rt_list_for_each_entry(a,b,c)=a=(void*)b;;ARCH_CPU_64BIT...

[cpp_check.py 80 INFO]
[cpp_check.py 79 INFO] Checking components/lwp/lwp.c ...
Checking components/lwp/lwp.c: RT_ASSERT(x)=;RTM_EXPORT(x)=;rt_list_for_each_entry(a,b,c)=a=(void*)b;;RT_USING_DFS=1;RT_USING_MUSLLIBC...

[cpp_check.py 80 INFO]
[cpp_check.py 79 INFO] Checking components/utilities/utest/utest.c ...

[cpp_check.py 80 INFO] components/utilities/utest/utest.c:26:2: error: #error "RT_CONSOLEBUF_SIZE is less than 256!" [preprocessorErrorDirective]
#error "RT_CONSOLEBUF_SIZE is less than 256!"
^

[cpp_check.py 79 INFO] Checking libcpu/aarch64/common/mmu.c ...
Checking libcpu/aarch64/common/mmu.c: RT_ASSERT(x)=;RTM_EXPORT(x)=;rt_list_for_each_entry(a,b,c)=a=(void*)b;...
Checking libcpu/aarch64/common/mmu.c: RT_ASSERT(x)=;RTM_EXPORT(x)=;rt_list_for_each_entry(a,b,c)=a=(void*)b;;ARCH_USING_ASID...
Checking libcpu/aarch64/common/mmu.c: RT_ASSERT(x)=;RTM_EXPORT(x)=;rt_list_for_each_entry(a,b,c)=a=(void*)b;;KERNEL_ASPACE_START...
Checking libcpu/aarch64/common/mmu.c: RT_ASSERT(x)=;RTM_EXPORT(x)=;rt_list_for_each_entry(a,b,c)=a=(void*)b;;RT_DEBUGGING_ALIASING...
Checking libcpu/aarch64/common/mmu.c: RT_ASSERT(x)=;RTM_EXPORT(x)=;rt_list_for_each_entry(a,b,c)=a=(void*)b;;RT_USING_SMART...

[cpp_check.py 80 INFO]
[cpp_check.py 111 ERROR] static code analysis(cppcheck) fail.
Error: Process completed with exit code 1.

2.
Static code analysis / Static code analysis (pull_request)Failing after 2m
In file included from drivers/imx6ull.h:18,
from drivers/board.h:14,
from drivers/board.c:18:
/home/runner/work/rt-thread/rt-thread/components/lwp/lwp.h:88:2: error: #error "No compatible lwp set status provided for this libc"
88 | #error "No compatible lwp set status provided for this libc"
| ^~~~~
In file included from drivers/imx6ull.h:18,
from drivers/board.h:14,
from drivers/bsp_clock.c:12:
/home/runner/work/rt-thread/rt-thread/components/lwp/lwp.h:88:2: error: #error "No compatible lwp set status provided for this libc"
88 | #error "No compatible lwp set status provided for this libc"
| ^~~~~
In file included from drivers/imx6ull.h:18,
from drivers/board.h:14,
from drivers/drv_common.c:14:
/home/runner/work/rt-thread/rt-thread/components/lwp/lwp.h:88:2: error: #error "No compatible lwp set status provided for this libc"
88 | #error "No compatible lwp set status provided for this libc"
| ^~~~~
In file included from drivers/imx6ull.h:18,
from drivers/board.h:14,
from drivers/drv_common.h:15,
from drivers/drv_adc.c:24:
/home/runner/work/rt-thread/rt-thread/components/lwp/lwp.h:88:2: error: #error "No compatible lwp set status provided for this libc"
88 | #error "No compatible lwp set status provided for this libc"
| ^~~~~
scons: *** [build/drivers/board.o] Error 1
scons: *** [build/drivers/bsp_clock.o] Error 1
drivers/drv_adc.c:32:17: warning: 'imx6ull_adc_convert' defined but not used [-Wunused-function]
32 | static rt_err_t imx6ull_adc_convert(struct rt_adc_device *device, rt_uint32_t channel, rt_uint32_t *value)
| ^~~~~~~~~~~~~~~~~~~
drivers/drv_adc.c:27:17: warning: 'imx6ull_adc_enabled' defined but not used [-Wunused-function]
27 | static rt_err_t imx6ull_adc_enabled(struct rt_adc_device *device, rt_uint32_t channel, rt_bool_t enabled)
| ^~~~~~~~~~~~~~~~~~~
scons: *** [build/drivers/drv_common.o] Error 1
scons: *** [build/drivers/drv_adc.o] Error 1
scons: building terminated because of errors.
scons -c
Error: build nxp/imx/imx6ull-smart failed
Error: Process completed with exit code 1.
我看和 .clang-format-ignore 修改无关，需要做什么使检查通过么？

不用处理，这是其他bsp遗留的问题，与该PR无关

utilize the clang-format-ignore mechanism in bsp/nxp

bb305ea

thomax2 requested a review from Rbb666 as a code owner October 16, 2025 14:13

github-actions bot added BSP: NXP Code related with NXP BSP labels Oct 16, 2025

Rbb666 requested a review from kurisaW October 17, 2025 14:03

Rbb666 linked an issue Oct 20, 2025 that may be closed by this pull request

[Feature] 推动clang-format-ignore机制 #10764

Closed

kurisaW requested changes Oct 21, 2025

View reviewed changes

fix: ignore files with known build issues exposed by migration

261b8c7

kurisaW approved these changes Oct 22, 2025

View reviewed changes

thomax2 requested a review from kurisaW October 22, 2025 07:53

Rbb666 added this to 单元测试（UTEST）Framework Nov 7, 2025

github-project-automation bot moved this to Todo in 单元测试（UTEST）Framework Nov 7, 2025

Rbb666 removed this from 单元测试（UTEST）Framework Nov 7, 2025

Rbb666 approved these changes Nov 7, 2025

View reviewed changes

Rbb666 merged commit 2e1cf8d into RT-Thread:master Nov 7, 2025
29 of 30 checks passed

Provide feedback

Saved searches

Use saved searches to filter your results more quickly

Comments

utilize the clang-format-ignore mechanism in bsp/nxp (#10764)#10827

utilize the clang-format-ignore mechanism in bsp/nxp (#10764)#10827
Rbb666 merged 2 commits intoRT-Thread:masterfrom
thomax2:master

thomax2 commented Oct 16, 2025 •

edited

Loading

Uh oh!

CLAassistant commented Oct 16, 2025 •

edited

Loading

Uh oh!

github-actions bot commented Oct 16, 2025

Uh oh!

github-actions bot commented Oct 16, 2025 •

edited

Loading

Uh oh!

kurisaW Oct 21, 2025

Uh oh!

Uh oh!

kurisaW Oct 21, 2025

Uh oh!

kurisaW Oct 21, 2025

Uh oh!

kurisaW Oct 21, 2025

Uh oh!

thomax2 Oct 22, 2025

Uh oh!

kurisaW Oct 22, 2025

Uh oh!

Uh oh!

Reviewers

Assignees

Labels

Projects

Milestone

Development

Uh oh!

4 participants

Comments

Conversation

thomax2 commented Oct 16, 2025 • edited Loading Uh oh! There was an error while loading. Please reload this page.

Uh oh!

拉取/合并请求描述：(PR description)

为什么提交这份PR (why to submit this PR)

你的解决方案是什么 (what is your solution)

请提供验证的bsp和config (provide the config and bsp)

当前拉取/合并请求的状态 Intent for your PR

代码质量 Code Quality：

Uh oh!

CLAassistant commented Oct 16, 2025 • edited Loading Uh oh! There was an error while loading. Please reload this page.

Uh oh!

Uh oh!

github-actions bot commented Oct 16, 2025

🛠 操作步骤 | Steps

Uh oh!

github-actions bot commented Oct 16, 2025 • edited Loading Uh oh! There was an error while loading. Please reload this page.

Uh oh!

📌 Code Review Assignment

🏷️ Tag: bsp_mcxa

🏷️ Tag: bsp_mcxn

📊 Current Review Status (Last Updated: 2025-10-22 10:24 CST)

📝 Review Instructions

Uh oh!

kurisaW Oct 21, 2025

Choose a reason for hiding this comment

Uh oh!

Uh oh!

kurisaW Oct 21, 2025

Choose a reason for hiding this comment

Uh oh!

kurisaW Oct 21, 2025

Choose a reason for hiding this comment

Uh oh!

kurisaW Oct 21, 2025

Choose a reason for hiding this comment

Uh oh!

thomax2 Oct 22, 2025

Choose a reason for hiding this comment

Uh oh!

kurisaW Oct 22, 2025

Choose a reason for hiding this comment

Uh oh!

Uh oh!

Reviewers

Assignees

Labels

Projects

Milestone

Development

Uh oh!

4 participants

thomax2 commented Oct 16, 2025 •

edited

Loading

CLAassistant commented Oct 16, 2025 •

edited

Loading

github-actions bot commented Oct 16, 2025 •

edited

Loading