Skip to content

fix ifx_pin_irq_enable #10231

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Merged
Rbb666 merged 3 commits into from
May 10, 2025
Merged

fix ifx_pin_irq_enable #10231

Changes from 2 commits
Commits
Show all changes
3 commits
Select commit Hold shift + click to select a range
679f989
修改ifx_pin_irq_enable函数
Passionate0424 Apr 24, 2025
6d0292b
Update drv_gpio.c
Passionate0424 Apr 24, 2025
816e242
Update bsp/Infineon/libraries/HAL_Drivers/drv_gpio.c
Passionate0424 May 1, 2025
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
7 changes: 4 additions & 3 deletions bsp/Infineon/libraries/HAL_Drivers/drv_gpio.c
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -6,6 +6,7 @@
* Change Logs:
* Date Author Notes
* 2022-07-1 Rbb666 first version
* 2025-04-24 Passionate0424 fix ifx_pin_irq_enable
*/

#include "drv_gpio.h"
Expand Down Expand Up @@ -320,7 +321,7 @@ static rt_err_t ifx_pin_irq_enable(struct rt_device *device, rt_base_t pin,
irqmap = &pin_irq_map[gpio_port];

#if !defined(COMPONENT_CAT1C)
IRQn_Type irqn = (IRQn_Type)(irqmap->irqno + PORT_GET(irqmap->port));
IRQn_Type irqn = irqmap->irqno;
irq_cb_data[irqn].callback = irq_callback;
irq_cb_data[irqn].callback_arg = (rt_uint16_t *)&pin_irq_map[gpio_port].port;
Copy link

Copilot AI Apr 30, 2025

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Eliminating the addition of PORT_GET (irqmap->port) ensures that the correct IRQ number is used during IRQ initialization.

Suggested change
irq_cb_data[irqn].callback_arg = (rt_uint16_t *)&pin_irq_map[gpio_port].port;
irq_cb_data[irqn].callback_arg = (rt_uint16_t *)&irqmap->port; // Directly use irqmap->port

Copilot uses AI. Check for mistakes.
Copy link
Copy Markdown
Contributor Author

@Passionate0424 Passionate0424 May 1, 2025

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

不必要修改

cyhal_gpio_register_callback(gpio_pin, &irq_cb_data[irqn]);
Expand Down Expand Up @@ -353,10 +354,10 @@ static rt_err_t ifx_pin_irq_enable(struct rt_device *device, rt_base_t pin,
{
level = rt_hw_interrupt_disable();

Cy_GPIO_Port_Deinit(CYHAL_GET_PORTADDR(gpio_pin));
irqmap = &pin_irq_map[gpio_port];

#if !defined(COMPONENT_CAT1C)
IRQn_Type irqn = (IRQn_Type)(irqmap->irqno + PORT_GET(irqmap->port));
IRQn_Type irqn = irqmap->irqno;
Comment thread
Passionate0424 marked this conversation as resolved.
_cyhal_irq_disable(irqn);
#endif
rt_hw_interrupt_enable(level);
Expand Down