-
Notifications
You must be signed in to change notification settings - Fork 2k
feat: implement native Sign in with Apple for Mac App Store #4794
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Draft
DIYgod
wants to merge
15
commits into
dev
Choose a base branch
from
DIYgod/native-apple-sign-in
base: dev
Could not load branches
Branch not found: {{ refName }}
Loading
Could not load tags
Nothing to show
Loading
Are you sure you want to change the base?
Some commits from the old base branch may be removed from the timeline,
and old review comments may become outdated.
Draft
Changes from all commits
Commits
Show all changes
15 commits
Select commit
Hold shift + click to select a range
35156db
feat: implement native Sign in with Apple for Mac App Store
DIYgod 19debf2
feat: enable native Sign in with Apple for all macOS builds
DIYgod d7fc54b
fix: prevent main thread deadlock in Apple auth helper
DIYgod ef3463a
fix: parse helper JSON from error.stdout on non-zero exit
DIYgod 39bff3d
fix: correct dev helper path for native Apple auth
DIYgod 7b8d271
fix: add Sign in with Apple entitlement to MAS child plist
DIYgod 0711938
ci: pass dev id provisioning profile
DIYgod c980c48
fix: restrict native Apple Sign In to MAS builds only
DIYgod 466f820
revert: remove dev id provisioning profile from workflow
DIYgod b41f769
fix: improve Apple auth error messages for debugging
DIYgod 7a7ef9d
fix: improve Apple auth helper window and add debug logging
DIYgod 0ef3a9a
fix: package AppleAuthHelper as .app bundle for Sign in with Apple
DIYgod 5726279
fix: remove directory-level Info.plist to fix Transporter validation
DIYgod c82486b
fix: use NSApp.run() for proper Touch ID handling and hide helper window
DIYgod e1f5afe
fix: use main app Bundle ID (is.follow) for AppleAuthHelper
DIYgod File filter
Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
There are no files selected for viewing
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
28 changes: 28 additions & 0 deletions
28
apps/desktop/resources/apple-auth-helper/AppleAuthHelper.app/Contents/Info.plist
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
| Original file line number | Diff line number | Diff line change |
|---|---|---|
| @@ -0,0 +1,28 @@ | ||
| <?xml version="1.0" encoding="UTF-8"?> | ||
| <!DOCTYPE plist PUBLIC "-//Apple//DTD PLIST 1.0//EN" "http://www.apple.com/DTDs/PropertyList-1.0.dtd"> | ||
| <plist version="1.0"> | ||
| <dict> | ||
| <key>CFBundleDevelopmentRegion</key> | ||
| <string>en</string> | ||
| <key>CFBundleExecutable</key> | ||
| <string>AppleAuthHelper</string> | ||
| <key>CFBundleIdentifier</key> | ||
| <string>is.follow</string> | ||
| <key>CFBundleInfoDictionaryVersion</key> | ||
| <string>6.0</string> | ||
| <key>CFBundleName</key> | ||
| <string>AppleAuthHelper</string> | ||
| <key>CFBundlePackageType</key> | ||
| <string>APPL</string> | ||
| <key>CFBundleShortVersionString</key> | ||
| <string>1.0</string> | ||
| <key>CFBundleVersion</key> | ||
| <string>1</string> | ||
| <key>LSMinimumSystemVersion</key> | ||
| <string>11.0</string> | ||
| <key>LSUIElement</key> | ||
| <true/> | ||
| <key>NSHighResolutionCapable</key> | ||
| <true/> | ||
| </dict> | ||
| </plist> |
Binary file added
BIN
+342 KB
apps/desktop/resources/apple-auth-helper/AppleAuthHelper.app/Contents/MacOS/AppleAuthHelper
Binary file not shown.
Oops, something went wrong.
Oops, something went wrong.
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Uh oh!
There was an error while loading. Please reload this page.