[rocRoller] Remove matchMemoryAccess from client.#3973
Merged
Conversation
perfci run on commit f6d19de |
ThanHenderson
approved these changes
Jan 21, 2026
Codecov Report✅ All modified and coverable lines are covered by tests. ❌ Your project status has failed because the head coverage (76.83%) is below the target coverage (80.00%). You can increase the head coverage or adjust the target coverage. Additional details and impacted files@@ Coverage Diff @@
## develop #3973 +/- ##
===========================================
- Coverage 66.04% 65.31% -0.73%
===========================================
Files 1608 1577 -31
Lines 256203 242095 -14108
Branches 35999 33901 -2098
===========================================
- Hits 169198 158104 -11094
+ Misses 71756 69991 -1765
+ Partials 15249 14000 -1249
*This pull request uses carry forward flags. Click here to find out more. 🚀 New features to boost your workflow:
|
jaopaulolc
approved these changes
Jan 23, 2026
Generated Documentation |
perfci run on commit 395abcc |
Code Coverage Report for gfx942Summary
This PR adds/edits 1771 newly uncovered lines. Artifacts
Commit Hashes |
Performance Report for gfx12ResultsDetails@@ Significant (p-val <0.05) Performance Diffs @@
====================================================================================================
- 1.20% | p=1.7451e-03
| CodeGen(instCount: 40000, instructions: comments)| CodeGen() | CodeGen(instCount: 40000, instructions: comments)
+ 4.54% | p=5.6994e-05
| CodeGen(instCount: 40000, instructions: complex_mi_with_coop)| CodeGen() | CodeGen(instCount: 40000, instructions: complex_mi_with_coop)
+ 2.58% | p=2.5347e-02
| CodeGen(instCount: 40000, instructions: simple_mi)| CodeGen() | CodeGen(instCount: 40000, instructions: simple_mi)
|
Resource Report for gfx12ResultsDetails✔️ No Resource Usage Changes ✔️ |
Performance Report for gfx950ResultsDetails@@ Significant (p-val <0.05) Performance Diffs @@
====================================================================================================
- 0.62% | p=7.0009e-03
| CodeGen(instCount: 40000, instructions: comments)| CodeGen() | CodeGen(instCount: 40000, instructions: comments)
|
Resource Report for gfx950ResultsDetails✔️ No Resource Usage Changes ✔️ |
perfci run on commit a47def5 |
Performance Report for gfx942ResultsDetails@@ Significant (p-val <0.05) Performance Diffs @@
====================================================================================================
+ 2.67% | p=5.6994e-05
| CodeGen(instCount: 40000, instructions: comments)| CodeGen() | CodeGen(instCount: 40000, instructions: comments)
+ 1.95% | p=1.7451e-03
| CodeGen(instCount: 40000, instructions: complex_mi_with_coop)| CodeGen() | CodeGen(instCount: 40000, instructions: complex_mi_with_coop)
|
Resource Report for gfx942ResultsDetails✔️ No Resource Usage Changes ✔️ |
perfci run on commit 7a8a3d2 |
perfci run on commit 7a8a3d2 |
kamuruga08
pushed a commit
that referenced
this pull request
Feb 19, 2026
## Motivation The `matchMemoryAccess` parameters is obsolete and was always set to True. ## Test Plan Rely on existing tests.
kamuruga08
pushed a commit
that referenced
this pull request
Feb 19, 2026
## Motivation The `matchMemoryAccess` parameters is obsolete and was always set to True. ## Test Plan Rely on existing tests.
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
4 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Motivation
The
matchMemoryAccessparameters is obsolete and was always set to True.Technical Details
Test Plan
Rely on exists tests.
Test Result