[rocsparse] Refactor conversion routine tests so that they conform to new test timing#3952
Closed
jsandham wants to merge 12 commits intoROCm:developfrom
Closed
[rocsparse] Refactor conversion routine tests so that they conform to new test timing#3952jsandham wants to merge 12 commits intoROCm:developfrom
jsandham wants to merge 12 commits intoROCm:developfrom
Conversation
… test_timings_conversion
Codecov Report✅ All modified and coverable lines are covered by tests. Additional details and impacted files@@ Coverage Diff @@
## develop #3952 +/- ##
============================================
+ Coverage 47.83% 69.70% +21.87%
============================================
Files 365 477 +112
Lines 51595 75651 +24056
Branches 5963 15541 +9578
============================================
+ Hits 24678 52732 +28054
+ Misses 24332 16437 -7895
- Partials 2585 6482 +3897
Flags with carried forward coverage won't be shown. Click here to find out more. 🚀 New features to boost your workflow:
|
… test_timings_conversion
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Motivation
This PR changes the conversion routine tests so that they conform to the test timing standards such that:
Before:
[==========] 38222 tests from 76 test suites ran. (1113641 ms total)
After:
./rocsparse-test --gtest_filter=conversion-nightly
[==========] 25454 tests from 76 test suites ran. (408261 ms total)