Fix bug when tuning fusions#2209
Merged
mirza-halilcevic merged 1 commit intodevelopfrom Jan 21, 2026
Merged
Conversation
Contributor
There was a problem hiding this comment.
Pull request overview
This PR fixes a bug in the tuning runner related to fusion operation configuration. The changes improve argument validation by ensuring --test-dir is properly required when tuning fusion operations and preventing its use with other operation types.
Changes:
- Added validation logic to enforce that
--test-dirmust be specified when--op=fusion - Moved
--test-dirargument to the mutually exclusive config group to prevent conflicts - Improved error message formatting for unsupported operation types
💡 Add Copilot custom instructions for smarter, more guided reviews. Learn how to get started.
justinrosner
approved these changes
Jan 21, 2026
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Motivation
Fix weekly CI issue when tuning fusions.
Technical Details
Add --test-dir to mutually exclusive argument group for configs, and validate correct usage together with --op.
Test Plan
Test Result
Submission Checklist