[Bugfix] Ensure radius defaults are applied when BilateralFilter diameter is <= 0#144
Open
zacharyvincze wants to merge 3 commits intoROCm:developfrom
Open
Conversation
There was a problem hiding this comment.
Pull request overview
Fixes BilateralFilter’s default-radius logic so the fallback radius is applied only when diameter <= 0 (instead of when the derived radius <= 0), aligning behavior with the intended API semantics and adding regression coverage.
Changes:
- Update radius computation in
dispatch_bilateral_filter_border_modeto use the default-radius formula only whendiameter <= 0. - Add Python and C++ test cases that exercise
diametervalues of0and-1. - Clarify the
diameterparameter documentation to describe the radius derivation rules.
Reviewed changes
Copilot reviewed 4 out of 4 changed files in this pull request and generated no comments.
| File | Description |
|---|---|
src/op_bilateral_filter.cpp |
Fixes radius selection logic so fallback radius depends on diameter <= 0. |
include/op_bilateral_filter.hpp |
Documents the updated diameter-to-radius behavior and sigmaSpace clamping. |
tests/roccv/python/test_op_bilateral_filter.py |
Adds parameterized test inputs with non-positive diameter. |
tests/roccv/cpp/src/tests/operators/test_op_bilateral_filter.cpp |
Adds CPU/GPU correctness tests for diameter <= 0 cases. |
💡 Add Copilot custom instructions for smarter, more guided reviews. Learn how to get started.
jeffqjiangNew
approved these changes
Apr 7, 2026
Codecov Report❌ Patch coverage is
Additional details and impacted files@@ Coverage Diff @@
## develop #144 +/- ##
===========================================
+ Coverage 74.26% 74.34% +0.07%
===========================================
Files 79 79
Lines 3357 3355 -2
Branches 738 738
===========================================
+ Hits 2493 2494 +1
+ Misses 382 380 -2
+ Partials 482 481 -1
🚀 New features to boost your workflow:
|
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Description