Skip to content

Conversation

@Meinersbur
Copy link

@Meinersbur Meinersbur commented Nov 25, 2025

llvm#169638 pre-merged into amd-staging

@github-actions
Copy link

Thank you for submitting a Pull Request (PR) to the LLVM Project!

This PR will be automatically labeled and the relevant teams will be notified.

If you wish to, you can add reviewers by using the "Reviewers" section on this page.

If this is not working for you, it is probably because you do not have write permissions for the repository. In which case you can instead tag reviewers by name in a comment by using @ followed by their GitHub username.

If you have received no comments on your PR for a week, you can request a review by "ping"ing the PR by adding a comment “Ping”. The common courtesy "ping" rate is once a week. Please remember that you are asking for valuable time from other developers.

If you have further questions, they may be answered by the LLVM GitHub User Guide.

You can also ask questions in a comment on this PR, on the LLVM Discord or on the forums.

@z1-cciauto
Copy link
Collaborator

@z1-cciauto
Copy link
Collaborator

@Meinersbur Meinersbur force-pushed the users/meinersbur/rocm_flang_builtin-mods branch from 0f93940 to a41ffe8 Compare November 25, 2025 16:08
@z1-cciauto
Copy link
Collaborator

@Meinersbur Meinersbur force-pushed the users/meinersbur/rocm_flang_builtin-mods branch from a41ffe8 to 4a8fef3 Compare December 1, 2025 19:14
@z1-cciauto
Copy link
Collaborator

@z1-cciauto
Copy link
Collaborator

@Meinersbur Meinersbur marked this pull request as ready for review December 2, 2025 14:42
@z1-cciauto
Copy link
Collaborator

@z1-cciauto
Copy link
Collaborator

@z1-cciauto
Copy link
Collaborator

@Meinersbur
Copy link
Author

Meinersbur commented Dec 9, 2025

@ronlieb Merged-in llvm@7675fc7. This includes all the patches since the last merge. Had to resolve two merge conflicts unrelated to the PR:

  • llvm/lib/Transforms/Vectorize/LoopVectorize.cpp: upstream inlined method
  • llvm/runtimes/CMakeLists.txt: ROCm 6.3 handling seems to be gone

The test 'flang/test/Integration/amdgpu/debug-target-var.f90' is failing. I think it is unrelated to llvm#169638

These were automatically resolved by kdiff3:

  • flang/test/Lower/OpenMP/target-enter-data-default-openmp52.f90
  • llvm/test/Transforms/LoopVectorize/AArch64/predicated-costs.ll

Had to add
74f496e

For aomp to build the amgdcn-amd-amdhsa modules, ROCm/aomp#1737 needs to be applied.

@z1-cciauto
Copy link
Collaborator

@z1-cciauto
Copy link
Collaborator

@Meinersbur Meinersbur force-pushed the users/meinersbur/rocm_flang_builtin-mods branch from 80634ae to 021eaa2 Compare December 10, 2025 14:13
@z1-cciauto
Copy link
Collaborator

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

3 participants