Skip to content

Support args, command for helm chart#122

Open
kwang1121 wants to merge 2 commits intoROCm:masterfrom
kwang1121:master
Open

Support args, command for helm chart#122
kwang1121 wants to merge 2 commits intoROCm:masterfrom
kwang1121:master

Conversation

@kwang1121
Copy link
Copy Markdown

This is a PR that adds support for configuring the args and command of the dp DaemonSet.

Comment thread helm/amd-gpu/values.yaml Outdated
Comment on lines +18 to +19
args: []
command: []
Copy link
Copy Markdown

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

The default CMD in the Dockerfile is as follows:

CMD ["./k8s-device-plugin", "-logtostderr=true", "-stderrthreshold=INFO", "-v=5"]

  command: ["./k8s-device-plugin"]
  args: ["-logtostderr=true", "-stderrthreshold=INFO", "-v=5"] 

How about changing it like this?

Copy link
Copy Markdown

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

3 participants