Add Python bindings for hipFile (GPU-direct storage on ROCm)#221
Closed
glimchb wants to merge 1 commit intoROCm:developfrom
Closed
Add Python bindings for hipFile (GPU-direct storage on ROCm)#221glimchb wants to merge 1 commit intoROCm:developfrom
glimchb wants to merge 1 commit intoROCm:developfrom
Conversation
glimchb
requested review from
derobins,
gaoikawa,
jordan-turbofish,
kurtmcmillan,
riley-dixon and
zbyrne
as code owners
ctypes-based Python package mirroring the cufile-python API so that LMCache can use hipFile as a drop-in replacement on ROCm. - Low-level bindings (bindings.py) wrapping libhipfile.so - High-level API with CuFile/CuFileDriver matching cufile exactly - Mock-based test suite (27 tests, runs without AMD hardware) - PyTorch integration example Fixes: ROCm#201 Signed-off-by: Boris Glimcher <Boris.Glimcher@emc.com>
Collaborator
|
Thank you @glimchb for the contribution suggestion here - really appreciate it - however the hipFile team will in all likelihood put the python bindings in another HIP/ROCm repo so that we follow the HIP/ROCm standard among other projects/libraries. We also need to figure out the process for publishing ROCm python wheels. It's on our short-term backlog to add python bindings for hipFile. In the meanwhile, if you need these bindings for other frameworks usage, we recommend forking our repo and then storing the changes in a branch on your fork. Thank you, |
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
ctypes-based Python package mirroring the cufile-python API so that
LMCache can use hipFile as a drop-in replacement on ROCm.
Fixes: #201
Motivation
Technical Details
Test Plan
Test Result
Submission Checklist