Skip to content

Conversation

@bartekxk
Copy link
Contributor

@bartekxk bartekxk commented Jan 19, 2026

[CK TILE] Fix basic gemm pipelines. Refactor and add missing local prefetch

Checklist

Please put an x into the boxes that apply. You can also fill these out after creating the PR. If you're not sure, please don't hesitate to ask.

  • I have added tests relevant to the introduced functionality, and the unit tests are passing locally
  • I have added the test to REGRESSION_TESTS list defined at the top of CMakeLists.txt in tests/CMakeLists.txt, IF the test takes more than 30 seconds to run.
  • I have added inline documentation which enables the maintainers with understanding the motivation
  • I have removed the stale documentation which is no longer relevant after this pull request
  • (If this change is user-facing) I have added release notes which provide the end users with a brief summary of the improvement from this pull request
  • I have run clang-format on all changed files
  • Any dependent changes have been merged

Discussion

If this is a relatively large or complex change, feel free to start a discussion by explaining why you chose the solution you did and what alternatives you considered

aosewski
aosewski previously approved these changes Jan 20, 2026
@aosewski aosewski requested a review from Copilot January 20, 2026 10:35
Copy link
Contributor

Copilot AI left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Pull request overview

This PR refactors the basic GEMM pipeline implementations (V1 and V2) by extracting common code into a base class and adding missing local prefetch operations to improve performance.

Changes:

  • Refactored GEMM pipeline implementations to use a base class for shared functionality
  • Added missing LocalPrefetch calls before block GEMM operations
  • Added pipeline type traits for BASIC_V1 and BASIC_V2 in convolution configs

Reviewed changes

Copilot reviewed 3 out of 3 changed files in this pull request and generated 2 comments.

File Description
include/ck_tile/ops/gemm/pipeline/gemm_pipeline_agmem_bgmem_creg_v2.hpp Refactored V2 pipeline to use base class and added local prefetch calls
include/ck_tile/ops/gemm/pipeline/gemm_pipeline_agmem_bgmem_creg_v1.hpp Refactored V1 pipeline to use base class and added local prefetch calls
example/ck_tile/20_grouped_convolution/conv_configs.hpp Added pipeline type traits for BASIC_V1 and BASIC_V2

💡 Add Copilot custom instructions for smarter, more guided reviews. Learn how to get started.

@bartekxk bartekxk enabled auto-merge (squash) January 20, 2026 11:27
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

3 participants