-
Notifications
You must be signed in to change notification settings - Fork 267
[CK TILE] Fix basic gemm pipelines #3611
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
base: develop
Are you sure you want to change the base?
Conversation
include/ck_tile/ops/gemm/pipeline/gemm_pipeline_agmem_bgmem_creg_v1.hpp
Outdated
Show resolved
Hide resolved
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Pull request overview
This PR refactors the basic GEMM pipeline implementations (V1 and V2) by extracting common code into a base class and adding missing local prefetch operations to improve performance.
Changes:
- Refactored GEMM pipeline implementations to use a base class for shared functionality
- Added missing
LocalPrefetchcalls before block GEMM operations - Added pipeline type traits for BASIC_V1 and BASIC_V2 in convolution configs
Reviewed changes
Copilot reviewed 3 out of 3 changed files in this pull request and generated 2 comments.
| File | Description |
|---|---|
| include/ck_tile/ops/gemm/pipeline/gemm_pipeline_agmem_bgmem_creg_v2.hpp | Refactored V2 pipeline to use base class and added local prefetch calls |
| include/ck_tile/ops/gemm/pipeline/gemm_pipeline_agmem_bgmem_creg_v1.hpp | Refactored V1 pipeline to use base class and added local prefetch calls |
| example/ck_tile/20_grouped_convolution/conv_configs.hpp | Added pipeline type traits for BASIC_V1 and BASIC_V2 |
💡 Add Copilot custom instructions for smarter, more guided reviews. Learn how to get started.
include/ck_tile/ops/gemm/pipeline/gemm_pipeline_agmem_bgmem_creg_v2.hpp
Outdated
Show resolved
Hide resolved
include/ck_tile/ops/gemm/pipeline/gemm_pipeline_agmem_bgmem_creg_v1.hpp
Outdated
Show resolved
Hide resolved
55411a8 to
a616e87
Compare
[CK TILE] Fix basic gemm pipelines. Refactor and add missing local prefetch
Checklist
Please put an
xinto the boxes that apply. You can also fill these out after creating the PR. If you're not sure, please don't hesitate to ask.clang-formaton all changed filesDiscussion
If this is a relatively large or complex change, feel free to start a discussion by explaining why you chose the solution you did and what alternatives you considered