Replace unsafe uses of std::unordered_map with SynchronizedCache#2221
Open
draganmladjenovic wants to merge 2 commits intomainfrom
Open
Replace unsafe uses of std::unordered_map with SynchronizedCache#2221draganmladjenovic wants to merge 2 commits intomainfrom
draganmladjenovic wants to merge 2 commits intomainfrom
Conversation
draganmladjenovic
requested review from
a team,
amd-ruitang3,
minmengdie and
valarLip
Contributor
🏷️ CI GuideRuns automatically on every PR:
Extended tests (opt-in via labels):
|
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
1 participant
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Motivation
#2201
Technical Details
No read-write use of std::unordered_map is thread safe.
Test Plan
None. Will inspect CI runs.
Test Result
None.
Submission Checklist