[ci] Re-enabling rccl tests with 4gpu machine setup#2831
Merged
Conversation
…into users/geomin12/4-gpu
Contributor
|
Verified that the changes we made have been run 10 times with re-run below and see it consistently passing on the 4GPU runner everytime. https://github.com/ROCm/TheRock/actions/runs/20830811494 CI runs are also going through fine. Approving this PR. |
araravik-psd
approved these changes
Jan 9, 2026
idass1990
reviewed
Jan 12, 2026
Contributor
Author
|
RCCL tests pass! https://github.com/ROCm/TheRock/actions/runs/20933033363/job/60159776298?pr=2831 landing this |
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Re-enabling RCCL tests with our 4GPU machine setup
I tested locally here:
rocrandcorrectly retrieving the runner: https://github.com/ROCm/TheRock/actions/runs/20836486058/job/59862300962rcclcorrectly retrieving the runner: https://github.com/ROCm/TheRock/actions/runs/20836486058/job/59862300974other archs: https://github.com/ROCm/TheRock/actions/runs/20836486058/job/59862412259
Closes #2264
Progress on #2616