Skip to content

[ml-libs] enable composable_kernel in build for gfx1152 + gfx1153#2809

Merged
amd-callumm merged 2 commits intomainfrom
users/amd-callumm/ck-gfx1153
Feb 20, 2026
Merged

[ml-libs] enable composable_kernel in build for gfx1152 + gfx1153#2809
amd-callumm merged 2 commits intomainfrom
users/amd-callumm/ck-gfx1153

Conversation

@amd-callumm
Copy link
Copy Markdown
Contributor

@amd-callumm amd-callumm commented Jan 7, 2026

Motivation

Include composable_kernel in TheRock build as part of gfx1152/1153 target bringup, and allow MIOpen to use it

Follow-up to prior changes to get CK working for these targets:

Technical Details

Add gfx1152/1153 to list of supported targets for ml-libs/composable_kernel. Match test_miopen.py filters to existing gfx115x targets.

Test Plan

  • Verify build
  • Locally, run MIOpen CI tests on gfx1152/1153 hardware (now that it is allowed to use composable_kernel)
  • Await CI results for PR

Test Result

  • MIOpen CI tests succeeding on hardware (not sure if they're exercising composable_kernel though...)
  • CI successful
  • No other observed issues

Submission Checklist

Comment thread build_tools/github_actions/test_executable_scripts/test_miopen.py Outdated
@marbre
Copy link
Copy Markdown
Member

marbre commented Jan 13, 2026

We had an issue with a history rewrite which confused the GH UI and the commits it is showing on your PR. Please make sure to update your branch e.g. in the GH UI via

image

Afterwards you need update your local branch via git pull.

Alternative git rebase solution

Alternatively you can manually update your branch locally by following the below instructions:

git checkout <yourbranch>
git fetch origin main
git rebase origin/main
git push --force-with-lease origin <yourbranch>

@amd-callumm amd-callumm force-pushed the users/amd-callumm/ck-gfx1153 branch 5 times, most recently from 0b46398 to b7aba29 Compare January 16, 2026 14:12
Copy link
Copy Markdown
Contributor

@geomin12 geomin12 left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

looks good but i added gfx1152 and gfx1153 as labels, so it will build those archs and make sure this works!

@amd-callumm amd-callumm force-pushed the users/amd-callumm/ck-gfx1153 branch from b7aba29 to 8740f84 Compare January 30, 2026 19:08
Copy link
Copy Markdown
Contributor

@mgehre-amd mgehre-amd left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Looks good

# TODO: There is no FP32 wmma on Navi, remove all FP32 conv tests. These should already be skipped via applicability for
# CK solvers
if AMDGPU_FAMILIES in ["gfx110X-all", "gfx1150", "gfx1151", "gfx120X-all"]:
if AMDGPU_FAMILIES in [
Copy link
Copy Markdown
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

i dont find the pr anymore but such a selection came up before and i had suggested something like

if any(prefix in AMDGPU_FAMILIES for prefix in ["gfx110", "gfx115", "gfx120"]):

@amd-callumm amd-callumm force-pushed the users/amd-callumm/ck-gfx1153 branch from 8740f84 to 073bc42 Compare February 19, 2026 17:49
@amd-callumm amd-callumm force-pushed the users/amd-callumm/ck-gfx1153 branch from 073bc42 to 4c207f9 Compare February 19, 2026 17:51
Copy link
Copy Markdown
Contributor

@geomin12 geomin12 left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

looks like builds pass, unfortunately we have no test machines to validate this but a build passing is good in my eyes

@amd-callumm amd-callumm merged commit d7e780f into main Feb 20, 2026
396 of 408 checks passed
@github-project-automation github-project-automation Bot moved this from TODO to Done in TheRock Triage Feb 20, 2026
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Projects

Status: Done

Development

Successfully merging this pull request may close these issues.

6 participants