Skip to content

Fixing the libstdc++ error in SLES OS. Moving the dependency to recommends instead of requires#2800

Merged
nunnikri merged 2 commits intomainfrom
users/nunnikri/dependency_correction
Jan 9, 2026
Merged

Fixing the libstdc++ error in SLES OS. Moving the dependency to recommends instead of requires#2800
nunnikri merged 2 commits intomainfrom
users/nunnikri/dependency_correction

Conversation

@nunnikri
Copy link
Copy Markdown
Contributor

@nunnikri nunnikri commented Jan 7, 2026

Fixing the libstdc++ error in SLES OS. Removing the libstdc++ dependency in rpm packages
Also added the hipify package to amdrocm-core

Motivation

SLES packages installation is failing with error
Problem: 1: nothing provides 'libstdc++' needed by the to be installed amdrocm-llvm7.11

Technical Details

Removing libstdc++ as a mandatory requirement

Copy link
Copy Markdown
Contributor

@raramakr raramakr left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

We can remove it from RPM

"RPMRecommends": [
"gcc",
"gcc-c++",
"glibc",
Copy link
Copy Markdown
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Can remove it from RPMRequires, but adding it to RPMRecommends will have the same effect when the user tries to install it in SLES
Better to remove from RPMRecommends as well.

@nunnikri nunnikri requested a review from raramakr January 8, 2026 18:41
Copy link
Copy Markdown
Contributor

@raramakr raramakr left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Please edit the commit message before merging. Now its just removing the dependency

@nunnikri nunnikri merged commit 682b340 into main Jan 9, 2026
47 of 49 checks passed
@github-project-automation github-project-automation Bot moved this from TODO to Done in TheRock Triage Jan 9, 2026
@nunnikri nunnikri deleted the users/nunnikri/dependency_correction branch January 9, 2026 14:42
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

Status: Done

Development

Successfully merging this pull request may close these issues.

2 participants