Add Python 3.10 Support for PyTorch Builds by subodh-dubey-amd · Pull Request #2782 · ROCm/TheRock

subodh-dubey-amd · 2026-01-06T11:57:20Z

Summary

Adds Python 3.10 to the PyTorch build matrix and updates documentation.

Base: This PR is based on PR #2779 (compatibility fixes) and will be merged after it.

Changes

Updated GitHub Actions workflows to include Python 3.10 in the build matrix:
- .github/workflows/release_portable_linux_pytorch_wheels.yml
- .github/workflows/release_windows_pytorch_wheels.yml
Updated RELEASES.md to reflect Python 3.10 support
Updated external-builds/pytorch/README.md minimum Python version to 3.10+

Motivation

Python 3.10 is still widely used and many users have requested support for it.

Test Plan

Build PyTorch wheels for Python 3.10 on Linux
Build PyTorch wheels for Python 3.10 on Windows
Run PyTorch smoke tests with Python 3.10

Merge Order

First merge PR Fix Python 3.10 Compatibility Issues #2779 (compatibility fixes)
Then merge this PR Add Python 3.10 Support for PyTorch Builds #2782 (workflow changes)

Results:

Release portable Linux PyTorch Wheels:
- https://github.com/ROCm/TheRock/actions/runs/21107222465
- https://github.com/ROCm/TheRock/actions/runs/21100966209
Release Windows PyTorch Wheels:
- https://github.com/ROCm/TheRock/actions/runs/21094631015
- https://github.com/ROCm/TheRock/actions/runs/21077437501

HereThereBeDragons

i approve this now, but as you already stated, this can only be merged after the infrastructure is there to actually build/run with python 3.10

marbre

What about the failing Linux build for gfx1153?

HereThereBeDragons · 2026-01-08T09:34:19Z

i removed my approval as there are plenty of new additions to this pr.

marbre · 2026-01-13T17:59:30Z

We had an issue with a history rewrite which confused the GH UI and the commits it is showing on your PR. Please make sure to update your branch e.g. in the GH UI via

Afterwards you need update your local branch via git pull.

- Updated the supported Python versions in RELEASES.md and external-builds/pytorch/README.md to include Python 3.10. - Modified GitHub workflows for portable Linux and Windows PyTorch wheels to reflect the updated Python version matrix. This change ensures compatibility with Python 3.10 across relevant documentation and CI configurations.

ScottTodd

Marking this as "reviewed" until the dependent changes are merged first.

We should also keep an eye on CI/CD resource usage as the expand the matrix like this. We should have paths through our testing workflows/instructions (https://github.com/ROCm/TheRock/blob/main/docs/development/github_actions_debugging.md#testing-release-workflows and other docs) that limit themselves to a smaller subset of versions so we aren't constantly paying the high costs.

## Summary This PR fixes Python 3.10 compatibility issues in the ROCm SDK test suite and S3 dependency management. **This PR should be merged before #2782.** ## Changes ### 1. Test Suite: -P Flag Fix The Python -P flag is only available in 3.11+. Removed the -P flag entirely from all the files below for all the python version to keep the code simpler. Files: `test/utils.py`, `test/base_test.py`, `test/core_test.py`, `test/devel_test.py`, `test/libraries_test.py` **Why it's ok to skip on Python 3.10 & Other Python version** - The flag simply doesn't exist for 3.10, so we can't use it. - Tests still function correctly—they just lack this additional isolation layer - to keep the code simpler and having consistency ### 2. S3 networkx Version Management - **Upload multiple versions**: networkx 3.4.2 (for Python 3.10) and latest (for Python 3.11+) - **Improved version marking**: Only 3.4.2 gets `>=3.10`, all other networkx versions get `>=3.11` - Future-proof: handles networkx 4.x and beyond - Enables correct pip resolution based on Python version ### 3. Code Improvements - Removed `cp310` skip to enable Python 3.10 wheels - Refactored `PACKAGES_PER_PROJECT` to use consistent list types ### 4. Fix : ExitCode.OK: numeric argument required File: `external-builds/pytorch/run_pytorch_tests.py` Exit code from file: ExitCode.OK B:\runner\_work\_temp\4b851658-eb53-4550-8a2a-18d9c21ad67a.sh: line 4: exit: ExitCode.OK: numeric argument required https://github.com/ROCm/TheRock/actions/runs/21066243924 ## Related - pytorch/pytorch#152191 (networkx compatibility) - Depends on: #2782 (Python 3.10 PyTorch builds)' Tests: Tests are run on the branch `users/subodh-dubey-amd/pytorch-310-testing`, to check if the compatibility fixes work with python 3.10 adition. The branch `users/subodh-dubey-amd/pytorch-310-testing` is merge of - `users/subodh-dubey-amd/python-310-compatibility-fixes` - `users/subodh-dubey-amd/pytorch-310-workflow-changes` Results: - Release portable Linux PyTorch Wheels: - https://github.com/ROCm/TheRock/actions/runs/21107222465 - https://github.com/ROCm/TheRock/actions/runs/21100966209 - Release Windows PyTorch Wheels: - https://github.com/ROCm/TheRock/actions/runs/21094631015 - https://github.com/ROCm/TheRock/actions/runs/21077437501 --------- Co-authored-by: Marius Brehler <marius.brehler@amd.com>

…changes

marbre · 2026-02-16T10:29:48Z

@subodh-dubey-amd why was this merged? I don't see an approval by any of the reviewers.

ScottTodd · 2026-02-16T16:36:22Z

@subodh-dubey-amd why was this merged? I don't see an approval by any of the reviewers.

Seems like the original approval still satisfied the branch protection ruleset:

marbre · 2026-02-16T18:59:50Z

@subodh-dubey-amd why was this merged? I don't see an approval by any of the reviewers.

Seems like the original approval still satisfied the branch protection ruleset:

I assume it was not dismissed and @HereThereBeDragons rather re-requested a review from herself. Well, next time :)

HereThereBeDragons · 2026-02-16T19:07:24Z

i tried to overwrite it - but apparently i tried it the wrong way :( if you look at the top you see i am set to "commented" and not "approved"

marbre · 2026-02-16T23:44:17Z

i tried to overwrite it - but apparently i tried it the wrong way :( if you look at the top you see i am set to "commented" and not "approved"

Re-requesting a review does not revoke an approval it will still be approved. You rather need to dismiss the review next time if the contributor does not take your feedback serious enough. See https://docs.github.com/en/pull-requests/collaborating-with-pull-requests/reviewing-changes-in-pull-requests/dismissing-a-pull-request-review.

github-project-automation Bot moved this to TODO in TheRock Triage Jan 6, 2026

github-project-automation Bot added this to TheRock Triage Jan 6, 2026

subodh-dubey-amd mentioned this pull request Jan 6, 2026

Fix Python 3.10 Compatibility Issues #2779

Merged

subodh-dubey-amd changed the base branch from main to users/subodh-dubey-amd/python-310-compatibility-fixes January 6, 2026 13:18

This was referenced Jan 6, 2026

Fix PyTorch Windows Pipeline for multiple GPU Architectures #2780

Closed

Add Python 3.14 support for PyTorch builds #2783

Closed

subodh-dubey-amd requested a review from HereThereBeDragons January 6, 2026 16:26

HereThereBeDragons approved these changes Jan 6, 2026

View reviewed changes

subodh-dubey-amd marked this pull request as ready for review January 6, 2026 16:34

marbre reviewed Jan 6, 2026

View reviewed changes

subodh-dubey-amd force-pushed the users/subodh-dubey-amd/python-310-compatibility-fixes branch 2 times, most recently from e67cd5a to 4cd42ee Compare January 8, 2026 08:24

subodh-dubey-amd changed the base branch from users/subodh-dubey-amd/python-310-compatibility-fixes to main January 8, 2026 09:28

subodh-dubey-amd force-pushed the users/subodh-dubey-amd/pytorch-310-workflow-changes branch from e04301e to b4372c4 Compare January 8, 2026 09:32

HereThereBeDragons self-requested a review January 8, 2026 09:33

subodh-dubey-amd force-pushed the users/subodh-dubey-amd/pytorch-310-workflow-changes branch 4 times, most recently from 9c27a63 to af63e4b Compare January 13, 2026 11:46

subodh-dubey-amd force-pushed the main branch from 7e9ba03 to 3077ce8 Compare January 13, 2026 12:08

subodh-dubey-amd requested review from a team and ScottTodd as code owners January 13, 2026 12:08

subodh-dubey-amd force-pushed the users/subodh-dubey-amd/pytorch-310-workflow-changes branch from af63e4b to 3a8ce09 Compare January 14, 2026 07:24

subodh-dubey-amd marked this pull request as draft January 14, 2026 17:33

ScottTodd reviewed Jan 16, 2026

View reviewed changes

subodh-dubey-amd marked this pull request as ready for review January 19, 2026 05:26

Merge branch 'main' into users/subodh-dubey-amd/pytorch-310-workflow-…

08f8db8

…changes

subodh-dubey-amd merged commit c565942 into main Feb 16, 2026
9 checks passed

subodh-dubey-amd deleted the users/subodh-dubey-amd/pytorch-310-workflow-changes branch February 16, 2026 10:11

github-project-automation Bot moved this from TODO to Done in TheRock Triage Feb 16, 2026

Provide feedback

Saved searches

Use saved searches to filter your results more quickly

Add Python 3.10 Support for PyTorch Builds#2782

Add Python 3.10 Support for PyTorch Builds#2782
subodh-dubey-amd merged 2 commits intomainfrom
users/subodh-dubey-amd/pytorch-310-workflow-changes

subodh-dubey-amd commented Jan 6, 2026 •

edited

Loading

Uh oh!

HereThereBeDragons left a comment

Uh oh!

marbre left a comment

Uh oh!

HereThereBeDragons commented Jan 8, 2026

Uh oh!

marbre commented Jan 13, 2026 •

edited

Loading

Uh oh!

ScottTodd left a comment

Uh oh!

Uh oh!

marbre commented Feb 16, 2026

Uh oh!

ScottTodd commented Feb 16, 2026

Uh oh!

marbre commented Feb 16, 2026 •

edited

Loading

Uh oh!

HereThereBeDragons commented Feb 16, 2026

Uh oh!

marbre commented Feb 16, 2026

Uh oh!

Reviewers

Assignees

Labels

Projects

Milestone

Development

Uh oh!

4 participants

Conversation

subodh-dubey-amd commented Jan 6, 2026 • edited Loading Uh oh! There was an error while loading. Please reload this page.

Uh oh!

Summary

Changes

Motivation

Test Plan

Merge Order

Uh oh!

HereThereBeDragons left a comment

Choose a reason for hiding this comment

Uh oh!

marbre left a comment

Choose a reason for hiding this comment

Uh oh!

HereThereBeDragons commented Jan 8, 2026

Uh oh!

marbre commented Jan 13, 2026 • edited Loading Uh oh! There was an error while loading. Please reload this page.

Uh oh!

Uh oh!

ScottTodd left a comment

Choose a reason for hiding this comment

Uh oh!

Uh oh!

marbre commented Feb 16, 2026

Uh oh!

ScottTodd commented Feb 16, 2026

Uh oh!

marbre commented Feb 16, 2026 • edited Loading Uh oh! There was an error while loading. Please reload this page.

Uh oh!

Uh oh!

HereThereBeDragons commented Feb 16, 2026

Uh oh!

marbre commented Feb 16, 2026

Uh oh!

Reviewers

Assignees

Labels

Projects

Milestone

Development

Uh oh!

4 participants

subodh-dubey-amd commented Jan 6, 2026 •

edited

Loading

marbre commented Jan 13, 2026 •

edited

Loading

marbre commented Feb 16, 2026 •

edited

Loading