[HIPIFY][Infra] workaround for long paths on Windows build#2384
Closed
kirthana14m wants to merge 1 commit intoamd-mainlinefrom
Closed
[HIPIFY][Infra] workaround for long paths on Windows build#2384kirthana14m wants to merge 1 commit intoamd-mainlinefrom
Windows build#2384kirthana14m wants to merge 1 commit intoamd-mainlinefrom
Conversation
kirthana14m
requested review from
kzhuravl,
lajagapp,
ranapratap55,
ronlieb and
skganesan008
kirthana14m
added
infrastructural
emankov
requested changes
Feb 11, 2026
Collaborator
emankov
left a comment
emankov
left a comment
There was a problem hiding this comment.
Despite the do not review label, I'm still forced to request changes.
| cd L: | ||
| ccache -z | ||
| python3 build_tools/github_actions/build_configure.py | ||
| cmake -B 'B:\build' -GNinja -S 'L:\' --preset windows-release -DTHEROCK_AMDGPU_FAMILIES=gfx1151 '-DCMAKE_C_COMPILER=C:\Program Files\Microsoft Visual Studio\2022\Community\VC\Tools\MSVC\14.44.35207\/bin/Hostx64/x64/cl.exe' '-DCMAKE_CXX_COMPILER=C:\Program Files\Microsoft Visual Studio\2022\Community\VC\Tools\MSVC\14.44.35207\/bin/Hostx64/x64/cl.exe' '-DCMAKE_LINKER=C:\Program Files\Microsoft Visual Studio\2022\Community\VC\Tools\MSVC\14.44.35207\/bin/Hostx64/x64/link.exe' -DTHEROCK_BACKGROUND_BUILD_JOBS=4 |
Collaborator
There was a problem hiding this comment.
- You should always use
""for paths instead of'', as in Windows CMD, single quotes are not string delimiters. - Targetting a very specific MSVS version, like
14.44.35207, is a bad solution. You should usevcvars64.batbeforehand. - Could you explain why and where the drive letter
Bhas appeared?
| set currentDir=%cd% | ||
|
|
||
| REM Substitute the current directory with L: drive | ||
| subst L: %currentDir% |
Collaborator
There was a problem hiding this comment.
UNSAFE! You should check a drive letter not in use.
Collaborator
Author
There was a problem hiding this comment.
Thanks for the comments @emankov
Currently, I am putting this PR on hold, and all changes are incorporated on #2383
- Updated the path to use "" instead of ''.
- Drive check and dynamic drive allocation has been added.
- We are static windows image, so the paths Build and MSCV are directly fetched for the build
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
No description provided.